Skip to content

Conversation

@MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented Apr 12, 2025

Pull Request Description

This PR updates React to the latest version and bumps some other related libraries for compatibility reasons.

Also this PR fixes breaking changes and removes forwardRef wrappers where they cause issues.

Updating react-aria-components caused significant perf degradation: adobe/react-spectrum#8086

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@github-actions
Copy link

github-actions bot commented Apr 12, 2025

🧪 Storybook is successfully deployed!

📊 Dashboard:

@MrFlashAccount MrFlashAccount changed the title React 19, react-aria-components 1.7, framer-motion 12, tanstack query 5.72 React 19, framer-motion 12, tanstack query 5.72 Apr 12, 2025
@farmaazon
Copy link
Contributor

farmaazon commented Apr 14, 2025

Bumping react-dom to 19 or above also requires veaury to be updated (and configured): https://github.com/gloriasoft/veaury?tab=readme-ov-file#if-react-dom-19-and-above-is-installed-in-your-vue-project-you-should-use-veaury260

GitHub
Use React in Vue3 and Vue3 in React, And as perfect as possible! - gloriasoft/veaury

@MrFlashAccount
Copy link
Contributor Author

@farmaazon Yeah I know. I already did it, but for some reason lazy vue components no longer display in dev mode after the update :(
Trying to solve the issue.

@MrFlashAccount MrFlashAccount force-pushed the wip/sergeigarin/react-19 branch from fff750e to 74a89f2 Compare May 6, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants