-
Notifications
You must be signed in to change notification settings - Fork 334
Conflict resolution for uploading projects to cloud #12899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… conflicting file found
MrFlashAccount
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one nit below
🧪 Storybook is successfully deployed!📊 Dashboard:
|
|
@PabloBuchu should be addressed now. i think the first dialog above is the old one so should be replaced with the new one at some point |
--- Before QA this PR should be rebased over #12899 --- Closes https://github.com/enso-org/cloud-v2/issues/1912 Please, refer to the issue for the scope of this PR.
|
Nope cant build to test |
|
@somebody1234 Now I can't upload any project to cloud. You are sending |
|
nice catch, thanks 😅 |
|
@PabloBuchu fixed |
|
Every time I click rename I get a default name even if I've changed it seconds ago... this is very misleading when I have multiple assets selected. Also probably we should add name taken validation as well Screen.Recording.2025-04-29.at.10.38.26.mp4 |
|
should be fixed now :( definitely need to be more consistent with self-testing & i think we should start thinking about adding more tests. this one i guess it's not trivial to add tests for because it requires local backend which isn't mocked yet but i assume not too difficult to add basic CRUD for. definitely not ideal vs a full integration test but i think it's worth the tradeoff of mocks being much faster/more reliable/less prone to network issues |




Pull Request Description
Important Notes
None
Testing Instructions
Possible Future Extensions
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,or the Snowflake database integration, a run of the Extra Tests has been scheduled.
If applicable, it is suggested to paste a link to a successful run of the Extra Tests.