Remove --update-manifest #14542
Merged
Remove --update-manifest #14542
+66
−272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a silent assumption that some manifest.yaml files were created ina distribution/** directories. Only in LibrariesTest.
Was needed only in `LibrariesTest` to discover `Standard.Base`.
Akirathan
added
CI: No changelog needed
It was only defined for Standard.Base
Akirathan
commented
Dec 30, 2025
Member
Author
There was a problem hiding this comment.
Changes in this test file ensures that language-server/test does not rely on buildEngineDistribution.
Previously, this test relied on the fact that there were manifest.yaml files created in distribution/lib/**. These files were created as part of buildEngineDistribution.
The manifest is only created with `--compile` cmdline option, not in PolyglotContext. Thus, it is easier to test it via a subprocess.
Akirathan
requested review from
4e6,
AdRiley,
GregoryTravis,
JaroslavTulach,
hubertp and
jdunkerley
as code owners
JaroslavTulach
approved these changes
Dec 31, 2025
AdRiley
approved these changes
Jan 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #14319 and #14469.
Pull Request Description
Removes
--update-manifeststandalone command from the engine runner. Instead, update manifest is done as part of--compile.Important Notes
--update-manifestcommand line option from engine runner--compilealso updates manifest - it createsmanifest.yamlfile in the project root directory with dependencies extracted from import statementsdistribution/lib/**/manifest.yamlfiles.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.