doc: add MinRuneLen/MaxRuneLen and clarify numeric Min/Max are inclusive#4486
Open
IceeAn wants to merge 1 commit intoent:masterfrom
Open
doc: add MinRuneLen/MaxRuneLen and clarify numeric Min/Max are inclusive#4486IceeAn wants to merge 1 commit intoent:masterfrom
IceeAn wants to merge 1 commit intoent:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that PR #4398 introduced the string validators
MinRuneLen/MaxRuneLen, but the documentation was not updated accordingly, so these two validators are currently not mentioned in the relevant docs. This PR adds documentation for MinRuneLen / MaxRuneLen.In addition,
Max()/Min()of Numeric types are inclusive, but the documentation uses strict>/<instead of>=/<=). I corrected it in this PR as well.