Skip to content

ENG-5026 plugin error handling #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
antromeo merged 4 commits into from
Jul 5, 2023
Merged

ENG-5026 plugin error handling #181

antromeo merged 4 commits into from
Jul 5, 2023

Conversation

@antromeo
Copy link
Contributor

@antromeo antromeo commented Jul 3, 2023

Wait for ENG-5006

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Requested publication of version 1.1.0-ENG-5026-PR-181

@antromeo antromeo closed this Jul 4, 2023
@antromeo antromeo reopened this Jul 4, 2023
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Requested publication of version 1.1.0-ENG-5026-PR-181

2 similar comments
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Requested publication of version 1.1.0-ENG-5026-PR-181

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Requested publication of version 1.1.0-ENG-5026-PR-181

@antromeo antromeo marked this pull request as ready for review July 4, 2023 12:58
@antromeo antromeo force-pushed the ENG-5026-plugin-error-handling branch from ce464b0 to 5711b70 Compare July 4, 2023 13:10
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Requested publication of version 1.1.0-ENG-5026-PR-181

avdev4j
avdev4j suggested changes Jul 4, 2023
View reviewed changes
@avdev4j
Copy link
Contributor

avdev4j commented Jul 4, 2023 •
edited
Loading

I tried to remove the plugin descriptor in my tested project (v1 bundle) but keep the entry in the main descriptor and no errors have been raised. Also, the output messages in the console don't match the examples included in the ticket. Any idea @antromeo ?

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Requested publication of version 1.1.0-ENG-5026-PR-181

@antromeo
Copy link
Contributor Author

antromeo commented Jul 4, 2023 •
edited
Loading

I tried to remove the plugin descriptor in my tested project (v1 bundle) but keep the entry in the main descriptor and no errors have been raised. Also, the output messages in the console don't match the examples included in the ticket. Any idea @antromeo ?

yes, the tool shouldn't break, if there is a plugin with a processing error, only the plugin with error will be skipped.
if you want to see more details in the console, you need to enable debug mode or check the log file

@antromeo antromeo merged commit 2e0b533 into develop Jul 5, 2023
@antromeo antromeo deleted the ENG-5026-plugin-error-handling branch July 5, 2023 14:51
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Requested publication of version 1.1.0-ENG-5026-PR-181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MEM2677 MEM2677 Awaiting requested review from MEM2677

@firegloves firegloves Awaiting requested review from firegloves

@alepintus alepintus Awaiting requested review from alepintus

1 more reviewer

@avdev4j avdev4j avdev4j approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antromeo @avdev4j