Separate patch processing within _com_interface_meta into a module.#646
Merged
junkmd merged 4 commits intoenthought:mainfrom Nov 2, 2024
Merged
Separate patch processing within _com_interface_meta into a module.#646junkmd merged 4 commits intoenthought:mainfrom
_com_interface_meta into a module.#646junkmd merged 4 commits intoenthought:mainfrom
Conversation
junkmd
added a commit
to junkmd/pywinauto
that referenced
this pull request
Nov 2, 2024
junkmd
force-pushed
the
separate_com_interface_patcher
branch
from
d442819 to
2134ce8
Compare
junkmd
force-pushed
the
separate_com_interface_patcher
branch
from
2134ce8 to
d87b718
Compare
junkmd
force-pushed
the
separate_com_interface_patcher
branch
from
d87b718 to
6de99dd
Compare
junkmd
force-pushed
the
separate_com_interface_patcher
branch
from
6de99dd to
3230f7a
Compare
junkmd
added a commit
to junkmd/pywinauto
that referenced
this pull request
Nov 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Within
_com_interface_meta,patch.Patcheris heavily used to define behaviors for dunder methods and pointers.Currently, the codebase has many use of
selfin different meanings and a deeply nested indentation level for the patched classes, making the code hard to read.By moving the sections defining the patched classes into a separate module, we can improve the readability of codebases of the metaclass.
To retain a change history, commits will be split, and this PR will be merged after several rounds of rebasing.