Replace Literal and Protocol with runtime-referable symbols.#651
Merged
junkmd merged 2 commits intoenthought:mainfrom Nov 2, 2024
Merged
Replace Literal and Protocol with runtime-referable symbols.#651junkmd merged 2 commits intoenthought:mainfrom
Literal and Protocol with runtime-referable symbols.#651junkmd merged 2 commits intoenthought:mainfrom
Conversation
and add the typing symbol to `shelllink`.
from `hints` to `tools.codegenerator.typeannotator`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an improvement for static typing.
When supporting versions earlier than Python 3.8, we used tricks combining
hints.pyiand type-hinting by string literals to utilizeLiteralandProtocol.Since version 1.4.7, support for versions earlier than Python 3.8 has been dropped, so
LiteralandProtocolcan now be used directly fromtyping.Dead version bridges in
hints.pyihave also been removed.