Skip to content

Improve PARAMFLAG_... and DISPATCH_... constants definitions and imports again.#806

Merged
junkmd merged 7 commits intoenthought:mainfrom
junkmd:improve_DISPATCH_PARAMFLAG_constants
Feb 16, 2025
Merged

Improve PARAMFLAG_... and DISPATCH_... constants definitions and imports again.#806
junkmd merged 7 commits intoenthought:mainfrom
junkmd:improve_DISPATCH_PARAMFLAG_constants

Conversation

@junkmd
Copy link
Copy Markdown
Collaborator

@junkmd junkmd commented Feb 16, 2025

In #805, I left a comment "so we don't have to import comtypes.automation to avoid a circular import" in _memberspec to document the reason for the duplicated constant definitions.

However, if we import the constants from _memberspec in the first place, duplication does not occur, and of course, neither does a circular import.

@junkmd junkmd added the coding style Topics related to style, formatters, linters, and delinting. label Feb 16, 2025
@junkmd junkmd added this to the 1.4.11 milestone Feb 16, 2025
junkmd added a commit to junkmd/pywinauto that referenced this pull request Feb 16, 2025
@junkmd junkmd merged commit f9e14c6 into enthought:main Feb 16, 2025
50 checks passed
@junkmd junkmd deleted the improve_DISPATCH_PARAMFLAG_constants branch February 16, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coding style Topics related to style, formatters, linters, and delinting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant