Replace client._code_cache._get_module_filename with typeinfo.GetModuleFileName.#811
Merged
junkmd merged 7 commits intoenthought:mainfrom Feb 20, 2025
Merged
Conversation
junkmd
changed the title
typeinfo.GetModuleFileName with client._code_cache._get_module_filename.client._code_cache._get_module_filename with typeinfo.GetModuleFileName.
junkmd
added a commit
to junkmd/pywinauto
that referenced
this pull request
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I previously defined
GetModuleFileNameintypeinfo, so there’s no longer a need to import the private function_get_module_filenamefrom the private moduleclient._code_cache.I also identified the conditions under which
GetModuleFileNameshould raise an error, so I added a branch to executeraise WinError.