Enhance ITypeInfo testing.
#884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test verifies the behavior of `ITypeInfo.GetRefTypeOfImplType` when called on a pure dispatch interface. It asserts that a `COMError` with `TYPE_E_ELEMENTNOTFOUND` is raised, which also serves as further validation for the recently corrected HRESULT constant.
This adds another test for `ITypeInfo.GetRefTypeOfImplType`, this time using a custom interface. This expands test coverage and further validates that `COMError` with `TYPE_E_ELEMENTNOTFOUND` is correctly raised for invalid calls.
… assertions. Replaced direct imports of `TKIND_DISPATCH` and `TKIND_INTERFACE` with qualified references (e.g., `typeinfo.TKIND_DISPATCH`) for consistency within `test_typeinfo.py`. Additionally, added assertions for `TYPEFLAG_FDUAL` in the tests for pure dispatch and dual interfaces to more thoroughly verify interface flags, especially for dual interfaces.
The `comtypes.hresult` import was replaced with a direct import from `comtypes`, and usages were updated accordingly. This change improves consistency with other imports in the module.
To align with internal conventions, the import for `COMError` has been changed from `comtypes` to the more direct `_ctypes` module.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #884 +/- ##
==========================================
+ Coverage 84.72% 84.76% +0.04%
==========================================
Files 125 125
Lines 11554 11587 +33
==========================================
+ Hits 9789 9822 +33
Misses 1765 1765 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon the recent fix for
TYPE_E_ELEMENTNOTFOUNDby adding more comprehensive tests forITypeInfo::GetRefTypeOfImplTypeand improving the overall quality of thetest_typeinfo.pymodule.Key Changes:
Expanded Test Coverage for
GetRefTypeOfImplType:GetRefTypeOfImplType(-1).TYPE_E_ELEMENTNOTFOUNDis correctly raised for non-dual interfaces.TYPEFLAG_FDUALflag for dual interfaces.Refactoring
test_typeinfo.py:hresultandCOMErrorfor better consistency.typeinfoconstants (e.g.,typeinfo.TKIND_DISPATCH) to improve clarity.Documentation:
tlbparser.pywith a link to the official Microsoft documentation forGetRefTypeOfImplType.