Skip to content

Fix list listener parsing#195

Merged
mdickinson merged 3 commits into
masterfrom
fix/list-listeners
Jun 16, 2014
Merged

Fix list listener parsing#195
mdickinson merged 3 commits into
masterfrom
fix/list-listeners

Conversation

@noraderam
Copy link
Copy Markdown
Contributor

Make it possible to define list listeners that are not at the end of a
listener group.

Currently, a listener on a list trait 'b[]' must be the last element defined in a list
of listeners--e.g. c = Property(depends_on=['a', 'b[]']). Putting the list
listener first (depends_on=['b[]', 'a']) causes an exception:
"TraitError: Expected '[]' at the end of an item at column 4 of 'b[],a'"
This issue also makes it impossible to listen to multiple lists.

Do not require a list member listener to be the final name parameter
@enbuilder
Copy link
Copy Markdown

Can one of the admins verify this patch?

@dpinte
Copy link
Copy Markdown
Member

dpinte commented Jun 4, 2014

@noraderam can you add a test replicating the original issue?

@noraderam
Copy link
Copy Markdown
Contributor Author

Sure, I've added a regression test.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) when pulling ad9be7a on fix/list-listeners into 83eb368 on master.

@dpinte
Copy link
Copy Markdown
Member

dpinte commented Jun 4, 2014

@noraderam thanks! Last thing is adding a line in the changelog

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) when pulling 44df0a2 on fix/list-listeners into 83eb368 on master.

@mdickinson
Copy link
Copy Markdown
Member

LGTM. The changelog needs some cleaning up at some point - at the moment it doesn't seem to be able to decide whether it's pretending to be Markdown or reST. That's for another PR, though.

@noraderam
Copy link
Copy Markdown
Contributor Author

@dpinte Do you have anything else on this?

@mdickinson
Copy link
Copy Markdown
Member

Merging. Thanks for the fix!

mdickinson added a commit that referenced this pull request Jun 16, 2014
@mdickinson mdickinson merged commit dbff916 into master Jun 16, 2014
@mdickinson mdickinson deleted the fix/list-listeners branch June 16, 2014 07:49
@mdickinson mdickinson mentioned this pull request Dec 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants