Conversation
Summary of ChangesHello @Hinne1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request prepares the repository for open-sourcing by sanitizing internal references, enhancing the installation process for public use, and updating legal documentation. The changes ensure that the repository is generic, accessible, and compliant for a wider audience. Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request does a good job of preparing the repository for open-sourcing. The changes, such as replacing internal project keys in AGENTS.md, updating the LICENSE, and switching to HTTPS for cloning in install.sh, are all necessary and well-executed steps. I've left one comment regarding a minor follow-up to the change in install.sh to improve user experience by making an error message consistent with the code change. Overall, the changes are solid and move the project in the right direction for a public release.
ba0cbe1 to
a9a54fb
Compare
fank
left a comment
There was a problem hiding this comment.
Review: Prepare repository for open-sourcing
The PR covers the critical items well — private CI action removed, internal project keys scrubbed from AGENTS.md, SSH→HTTPS fallback fixed, and LICENSE updated. Good work.
However, a few community-standard files are missing that should be added before going public:
Requested changes
-
Add
CONTRIBUTING.md— Guide for external contributors: how to report bugs, submit PRs, development setup (make build,make test,make lint), and code style expectations. -
Add
SECURITY.md— Instructions for reporting security vulnerabilities privately (e.g., via email or GitHub Security Advisories) instead of public issues. -
Add
CODE_OF_CONDUCT.md— Community standard for public repos. The Contributor Covenant is a common choice.
These are expected by the open source community and signal that the project is ready for external participation.
|
Thanks for the review. Regarding the community-standard files:
I'll push these in a follow-up commit. |
- Replace internal project key references with generic placeholders in AGENTS.md - Remove license validator workflow (references private org action) - Add .claude/ to .gitignore - Use HTTPS instead of SSH for install.sh clone fallback - Update LICENSE copyright holder to enthus GmbH
|
Checked again — no new commits since the review. The three requested files (CONTRIBUTING.md, SECURITY.md, CODE_OF_CONDUCT.md) are still missing. |
Add CONTRIBUTING.md, SECURITY.md, and CODE_OF_CONDUCT.md as requested in PR review.
a9a54fb to
edac47c
Compare
fank
left a comment
There was a problem hiding this comment.
All requested changes addressed. LGTM.
Summary
NX) with genericPROJin AGENTS.md exampleslicense_go.ymlworkflow (references privateenthus-appdev/actionsrepo).claude/to.gitignoreinstall.shclone fallback (public accessibility)enthus GmbHContext
Preparing this repository to be made public.
Test plan
make buildstill worksinstall.shworks without SSH keys configured