Merged
Conversation
Same proven pattern from esq-cli (validated end-to-end on v1.1.3): replace the hand-rolled bash release pipeline with GoReleaser v2. Differences from esq-cli config: - Added -X main.date ldflag (atl-cli uses version, commit, and date) - Formula name: atl - Formula description matches the repo description
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a .goreleaser.yml configuration file to automate the build and release process for the atl CLI. The review identifies two critical configuration issues related to the use of GoReleaser v2: the github block under release should be replaced with repository, and the brews section should be renamed to homebrews to ensure compatibility and correct execution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates atl-cli to GoReleaser — same proven pattern from esq-cli (validated end-to-end on v1.1.3: release + automatic formula push to homebrew-tap).
Changes
.goreleaser.yml— declarative config for builds, archives, checksums, changelog, release, and Homebrew tap push.github/workflows/release.yml— from ~138 lines of hand-rolled bash to ~47 linesOnly difference from esq-cli's config: adds
-X main.date={{.Date}}ldflag (atl-cli injects build date).Validated by
esq-cli v1.1.3 released successfully with this exact pattern — GoReleaser built all 6 platform binaries, created the GitHub Release, and pushed the formula to
enthus-appdev/homebrew-tapvia theenthus-appdev-tap-bumperGitHub App.Test plan
.goreleaser.ymlpassesgoreleaser check