feat: Add Jira Service Management OAuth scope and CLI commands#51
Merged
Conversation
Add read:servicedesk-request scope to enable API calls to the JSM service desk endpoints (e.g. request types, fields). Without this scope, any curl/API call to /rest/servicedeskapi/ returns 401.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds the read:servicedesk-request scope to the default OAuth scopes for Jira Service Management. The reviewer suggests including read:servicedesk and write:servicedesk-request to facilitate service desk discovery and ensure consistency with other service permissions.
Add 'atl sm' command group with:
- atl sm service-desk list — list service desks
- atl sm request-type list — list request types for a service desk
- atl sm request-type fields — list fields for a request type
Follows existing patterns: API service layer (api/sm.go), cobra
commands with --json support, table output for terminal use.
Note: Configuration uses map[string]interface{} to handle mixed-type
values (strings + booleans) that the Jira API returns, avoiding the
upstream go-atlassian bug that prompted this work (NX-15519).
ktaganova
changed the title
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
read:servicedesk-requestOAuth scope to enable JSM API accessatl smcommand group for Jira Service Management:atl sm service-desk list— list service desksatl sm request-type list --service-desk-id <id>— list request typesatl sm request-type fields --service-desk-id <id> --request-type-id <id>— list fields for a request type--jsonflag for structured outputContext
Discovered while debugging NX-15519 — needed to query request type fields via the JSM API to verify a fix, but the atl CLI lacked both the OAuth scope and any SM commands.
Test plan
atl auth loginafter updating — verify token includesread:servicedesk-requestatl sm service-desk list— verify service desks are listedatl sm request-type list --service-desk-id 2— verify request types listedatl sm request-type fields --service-desk-id 2 --request-type-id 26— verify fields listed--jsonflag — verify structured JSON outputgo test ./...— all tests pass