Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces project-scoping for variables by updating the API client and adding a "--project" flag to all variable CLI subcommands. The "list" command now conditionally displays a project column when project-scoped variables are present. Review feedback suggests improving the API client's consistency by returning a "*ListResult" with pagination support, refactoring the CLI table rendering to reduce duplication, and defining the "--project" flag as a persistent flag on the parent command to minimize boilerplate.
Address PR review feedback: - Move --project flag to parent command as persistent flag - Deduplicate table rendering into single loop with conditional format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--projectflag to all variable subcommands (list,get,create,update,delete) to support n8n's project-scoped variables (GA since n8n v1.118.0)ProjectIDfield toVariablestruct and threadsprojectIdthroughListVariablesandCreateVariableAPI methodsvariable listdynamically shows a PROJECT column when any returned variable is project-scopedUsage
Test plan
go build ./...compiles cleanlygo vet ./...passesn8nctl variable list --helpshows--projectflagn8nctl variable create --helpshows--projectflagn8nctl variable liststill works without--project(backward compatible)n8nctl variable create key val --project <id>creates a project-scoped variablen8nctl variable list --project <id>filters to that project's variables