Fix build: qualify isTerminalWriter in activity_cmd.go#1013
Merged
gtrrz-victor merged 1 commit intomainfrom Apr 23, 2026
Merged
Fix build: qualify isTerminalWriter in activity_cmd.go#1013gtrrz-victor merged 1 commit intomainfrom
gtrrz-victor merged 1 commit intomainfrom
Conversation
main broken after PR #999 (activity) + PR #1011 (simplify-tty-detection) merged without reconciling: activity_cmd.go calls unqualified `isTerminalWriter`, but the function lives in the `interactive` package (siblings status_style.go, search_cmd.go, explain.go all qualify with `interactive.IsTerminalWriter`). Add the import and qualify the call. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Entire-Checkpoint: a595e477f483
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a build break in the entire activity command by using the shared TTY-detection helper from the interactive package, aligning this file with other CLI call sites.
Changes:
- Import
cmd/entire/cli/interactiveinactivity_cmd.go - Replace the unqualified
isTerminalWriter(w)call withinteractive.IsTerminalWriter(w)to restore compilation
Soph
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/entireio/cli/trails/058a346a8f5c
Summary
cmd/entire/cli/activity_cmd.go:65calls unqualifiedisTerminalWriter, which doesn't exist in packagecli— the helper lives ininteractive(interactive.IsTerminalWriter).status_style.go,search_cmd.go,explain.go) already qualify it correctly. The mismatch slipped in when PR Addentire activity#999 (Add entire activity) landed alongside PR Consolidate TTY detection into interactive package #1011 (simplify-tty-detection) without reconciliation.go buildwithundefined: isTerminalWriter.Fix
Add the
interactiveimport and qualify the call. One-line change plus import.Test plan
go build ./...succeeds locallymise run fmt && mise run lintclean🤖 Generated with Claude Code
Note
Low Risk
Low risk: fixes a compile-time undefined symbol by calling the existing
interactive.IsTerminalWriter, with no behavioral change beyond restoring the intended terminal detection.Overview
Fixes a build break in
activity_cmd.goby importinginteractiveand switching the non-interactive fallback check from an undefinedisTerminalWritertointeractive.IsTerminalWriter.Reviewed by Cursor Bugbot for commit c56b7ac. Configure here.