Closed
Conversation
Entire-Checkpoint: 554522808ee9
Entire-Checkpoint: 45e8a336c18f
Drop the redundant 'h does not quit' case; vim 'k' already exercises the non-quit scroll path. Trim the footer hidden-controls assertion to the bindings that actually exist (j/k, g/G). Rename wantTop to gotoTop so the field name reflects its setup role rather than the expected outcome. Entire-Checkpoint: 867ea7a38ed5
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the activity TUI’s navigation/quit key handling and footer help to match the repo’s newer TUI navigation vocabulary, and adds focused unit tests to lock in the behavior.
Changes:
- Add
home/endand hiddeng/Gtop/bottom navigation handling in the activity viewport, while keepingq/esc/ctrl+cquit behavior. - Update the footer help text to document only visible controls (arrow scrolling, home/end, q quit).
- Add Bubble Tea model tests covering key handling and footer help content.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cmd/entire/cli/activity_tui.go | Updates key handling for top/bottom navigation and refreshes the footer help text. |
| cmd/entire/cli/activity_tui_test.go | Adds unit tests for activity TUI key handling and footer help visibility rules. |
Entire-Checkpoint: d2bc5c1d00be
Contributor
Author
|
Bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f042aa9. Configure here.
alishakawaguchi
previously approved these changes
Apr 27, 2026
Entire-Checkpoint: 0498b5f971b1
Entire-Checkpoint: f7c16f9a5955
Soph
approved these changes
Apr 28, 2026
gtrrz-victor
approved these changes
Apr 28, 2026
Collaborator
|
did some refactoring and introduced bindings, was easier to redo then: #1064 Sorry! |
auto-merge was automatically disabled
April 28, 2026 13:05
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
How
Verification
Note
Low Risk
Low risk: changes are limited to TUI key handling/footer rendering plus new unit tests, with no impact on backend logic or data handling.
Overview
Updates the activity TUI to support
home/endandg/Gfor jumping to the top/bottom of the viewport while preserving quit behavior (q,ctrl+c,esc).Refreshes the footer help text to document arrow + vim-style navigation and reworks scroll-percent alignment using rendered widths so it fits the terminal width.
Moves the shared
esckey string into a newtui_keys.goconstant and adds focused Bubble Tea tests covering key handling and footer rendering/width.Reviewed by Cursor Bugbot for commit f042aa9. Configure here.