Skip to content

Align search TUI navigation help#1058

Merged
gtrrz-victor merged 3 commits intomainfrom
feat/advanced-entire-search-key-bindings
Apr 28, 2026
Merged

Align search TUI navigation help#1058
gtrrz-victor merged 3 commits intomainfrom
feat/advanced-entire-search-key-bindings

Conversation

@pfleidi
Copy link
Copy Markdown
Contributor

@pfleidi pfleidi commented Apr 28, 2026

https://entire.io/gh/entireio/cli/trails/247

What

  • Aligns the entire search TUI help and navigation vocabulary with the newer interactive command conventions.
  • Keeps search as a single-screen TUI and preserves existing / search plus conditional n/p paging help.
  • Fixes dispatch TUI tests that mutated a package-level test hook while running in parallel.

How

  • Adds hidden vim-style and top/bottom browse-mode aliases: j/k, h, g/G, home/end.
  • Updates the footer to compact dot-separated hints: / search · ↑/↓, j/k scroll · home/end, g/G top/bottom · q quit, with n/p page still conditional.
  • Adds focused model tests for the new search key behavior and help text.
  • Removes t.Parallel() from dispatch tests that override newDispatchProgram.

Verification

  • go test -race ./cmd/entire/cli -run 'TestDefaultRunInteractiveDispatch_(DoesNotUseAltScreen|ClearsLoadingCardBeforeReturn)' -count=1
  • mise run build
  • mise run lint
  • mise run test:ci:core
  • mise run test:ci:integration:shard -- a
  • mise run test:ci:integration:shard -- b
  • mise run test:ci:integration:shard -- c
  • mise run test:e2e:canary

Note

Low Risk
Low risk: changes are limited to interactive search TUI keybindings/help text plus additional tests, and removes parallelism in two dispatch tests to avoid a package-level hook race.

Overview
Aligns the entire search interactive TUI navigation and footer help with newer conventions by standardizing escape handling via tuiEscKey, adding browse-mode aliases (h/Esc quit, home/g top, end/G bottom), and updating the on-screen help text accordingly.

Expands search_tui_test.go coverage for the new key behaviors and revised footer rendering (including conditional n/p paging hints), and fixes dispatch TUI flakiness by removing t.Parallel() from tests that override the package-level newDispatchProgram hook.

Reviewed by Cursor Bugbot for commit d8746bc. Configure here.

pfleidi added 3 commits April 27, 2026 16:58
Entire-Checkpoint: 9248b63b5995
Entire-Checkpoint: 53ab3f3a351f
Copilot AI review requested due to automatic review settings April 28, 2026 00:29
@pfleidi pfleidi requested a review from a team as a code owner April 28, 2026 00:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the entire search interactive TUI to use newer, consistent navigation/help vocabulary and fixes a parallel-test race in dispatch TUI tests.

Changes:

  • Add vim-style browse navigation aliases (j/k, g/G, home/end) and additional quit keys (esc, h) for the search TUI.
  • Refresh the search TUI footer help to a compact, dot-separated format with conditional paging hints.
  • Add targeted model tests for the new key behavior and help text; remove t.Parallel() from dispatch tests that mutate a package-level hook.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
cmd/entire/cli/search_tui.go Adds new browse-mode key aliases and updates help/footer rendering.
cmd/entire/cli/search_tui_test.go Adds/updates unit tests covering new navigation keys and updated footer help.
cmd/entire/cli/dispatch_tui_test.go Removes parallelization in tests that override a package-level factory to avoid races.

Comment thread cmd/entire/cli/search_tui.go
@gtrrz-victor gtrrz-victor merged commit 8a505b1 into main Apr 28, 2026
14 checks passed
@gtrrz-victor gtrrz-victor deleted the feat/advanced-entire-search-key-bindings branch April 28, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants