Align search TUI navigation help#1058
Merged
gtrrz-victor merged 3 commits intomainfrom Apr 28, 2026
Merged
Conversation
Entire-Checkpoint: 9248b63b5995
Entire-Checkpoint: d3ee8d5b009f
Entire-Checkpoint: 53ab3f3a351f
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the entire search interactive TUI to use newer, consistent navigation/help vocabulary and fixes a parallel-test race in dispatch TUI tests.
Changes:
- Add vim-style browse navigation aliases (
j/k,g/G,home/end) and additional quit keys (esc,h) for the search TUI. - Refresh the search TUI footer help to a compact, dot-separated format with conditional paging hints.
- Add targeted model tests for the new key behavior and help text; remove
t.Parallel()from dispatch tests that mutate a package-level hook.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/entire/cli/search_tui.go | Adds new browse-mode key aliases and updates help/footer rendering. |
| cmd/entire/cli/search_tui_test.go | Adds/updates unit tests covering new navigation keys and updated footer help. |
| cmd/entire/cli/dispatch_tui_test.go | Removes parallelization in tests that override a package-level factory to avoid races. |
gtrrz-victor
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/entireio/cli/trails/247
What
entire searchTUI help and navigation vocabulary with the newer interactive command conventions./search plus conditionaln/ppaging help.How
j/k,h,g/G,home/end./ search · ↑/↓, j/k scroll · home/end, g/G top/bottom · q quit, withn/p pagestill conditional.t.Parallel()from dispatch tests that overridenewDispatchProgram.Verification
go test -race ./cmd/entire/cli -run 'TestDefaultRunInteractiveDispatch_(DoesNotUseAltScreen|ClearsLoadingCardBeforeReturn)' -count=1mise run buildmise run lintmise run test:ci:coremise run test:ci:integration:shard -- amise run test:ci:integration:shard -- bmise run test:ci:integration:shard -- cmise run test:e2e:canaryNote
Low Risk
Low risk: changes are limited to interactive search TUI keybindings/help text plus additional tests, and removes parallelism in two dispatch tests to avoid a package-level hook race.
Overview
Aligns the
entire searchinteractive TUI navigation and footer help with newer conventions by standardizing escape handling viatuiEscKey, adding browse-mode aliases (h/Esc quit,home/gtop,end/Gbottom), and updating the on-screen help text accordingly.Expands
search_tui_test.gocoverage for the new key behaviors and revised footer rendering (including conditionaln/ppaging hints), and fixes dispatch TUI flakiness by removingt.Parallel()from tests that override the package-levelnewDispatchProgramhook.Reviewed by Cursor Bugbot for commit d8746bc. Configure here.