Merged
Conversation
Delete four tests that don't earn their keep: - TestCheckpointInfo_JSONRoundTrip and TestSessionState_JSONRoundTrip are pure stdlib JSON round-trips. The same struct shape is exercised end-to-end by TestShadow_SessionStateLocation and any test that runs a real session through .git/entire-sessions/. - TestOpenRepository and TestOpenRepositoryError smoke-test go-git itself. Every strategy method called from integration tests runs OpenRepository implicitly; failure surfaces as a setup error immediately. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 8f1c6f452ed9
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces redundant/unit “tautology” coverage in the strategy package by removing tests that primarily re-validate stdlib JSON behavior and go-git smoke behavior already exercised by higher-level integration tests.
Changes:
- Removed JSON round-trip tests for
CheckpointInfoandSessionStatefrommanual_commit_test.go. - Removed
OpenRepositorysmoke tests fromcommon_test.go.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/entire/cli/strategy/manual_commit_test.go | Deletes JSON marshal/unmarshal round-trip tests that are covered end-to-end elsewhere. |
| cmd/entire/cli/strategy/common_test.go | Deletes go-git/OpenRepository smoke tests that are exercised implicitly by integration strategy flows. |
Soph
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/entireio/cli/trails/264
Summary
TestCheckpointInfo_JSONRoundTripandTestSessionState_JSONRoundTrip— pure stdlib JSON round-trip tautologies. The same struct shape is exercised end-to-end byTestShadow_SessionStateLocationand any test that runs a real session through.git/entire-sessions/.TestOpenRepositoryandTestOpenRepositoryError— smoke tests of go-git itself. Every strategy method called from integration tests runsOpenRepositoryimplicitly; failure surfaces as a setup error immediately.Coverage that stays:
CheckpointInfo/SessionStateround-tripping →TestShadow_SessionStateLocationand the broaderTestShadow_*integration suite.OpenRepository→ exercised implicitly by every strategy method inintegration_test/.Test plan
mise run fmt— cleanmise run lint— 0 issues (no stranded imports)go test ./cmd/entire/cli/strategy/...— adjacent strategy tests passgo test -tags integration -run TestShadow ./cmd/entire/cli/integration_test/— subsuming integration tests pass🤖 Generated with Claude Code