Clean up migration output#1089
Merged
computermode merged 1 commit intomainfrom May 1, 2026
Merged
Conversation
Entire-Checkpoint: 500a1b5d8242
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the entire migrate --checkpoints v2 UX by suppressing per-checkpoint stdout chatter, showing terminal-friendly progress, and printing a concise completion summary with aggregate counts and guidance on where to find details.
Changes:
- Added a terminal-aware progress bar helper for long-running CLI operations.
- Refactored v1→v2 migration to write detailed per-checkpoint outcomes to structured logs instead of stdout, while tracking additional outcome counters.
- Updated migration tests to assert quiet stdout and added unit tests for the completion-summary messaging.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/entire/cli/progress.go | Adds a simple progress bar implementation for terminal writers. |
| cmd/entire/cli/migrate.go | Reworks migration output: progress on stderr, summary on stdout, detailed info via logging, and adds richer result accounting. |
| cmd/entire/cli/migrate_test.go | Updates expectations for quiet stdout and adds coverage for the completion summary behavior. |
pfleidi
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up the migration output such that it's a prettier progress bar rather than a long list of logged checkpoints. It prints out the # of checkpoints that were migrated, skipped, or failed at the end (and mentions where to find more info if needed in the logs).
Note
Medium Risk
Mostly changes user-facing output and observability for v1→v2 checkpoint migration, but it refactors migration control flow and return values (e.g., backfill/repair outcomes) which could subtly affect migration counting and error handling.
Overview
Refactors v1→v2 checkpoint migration output to be quiet by default: migration now renders a terminal progress bar (to stderr) and prints only a final completion summary, with skip/missing/compaction/backfill/repair details written to
.entire/logs/entire.log.Migration now tracks richer results (
missingSessions,compactTranscriptSkipped,backfilledCompactTranscripts,repaired) and converts previously printed per-checkpoint warnings/notes into structured log entries;backfillCompactTranscriptsalso returns a backfilled count instead of printing output.Updates tests to assert on the new result counters and the absence/presence of stdout text, and adds
printMigrateCompletioncoverage for when log-path guidance should be shown.Reviewed by Cursor Bugbot for commit 8b4404b. Configure here.