feat(review): add findings fix workflow#1145
Merged
peyton-alt merged 2 commits intomainfrom May 7, 2026
Merged
Conversation
Entire-Checkpoint: 76f412447fda
Contributor
Author
|
@BugBot review |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a local “review findings” + “apply fixes” workflow to the entire review command by persisting per-run manifests (including sibling agent outputs and optional aggregate synthesis) and introducing new CLI entry points for browsing and applying findings, with a saved default fix-agent preference.
Changes:
- Persist local review manifests per
entire reviewrun (agent session IDs, outputs, and optional aggregate synthesis result) and print follow-up--fixcommands after completion. - Add
entire review --findingsfor browsing manifests andentire review --fix [session-id] [--all]for selecting sources/findings and launching a fix agent. - Add
review_fix_agentsetting and picker/selection logic to remember the preferred agent for aggregate/multi-agent fixes.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/entire/cli/settings/settings.go | Adds review_fix_agent to settings and merges it from local overrides. |
| cmd/entire/cli/settings/settings_test.go | Extends settings round-trip test to cover review_fix_agent. |
| cmd/entire/cli/review/synthesis_sink.go | Adds OnResult callback to capture synthesis output for manifests. |
| cmd/entire/cli/review/synthesis_sink_test.go | Tests OnResult callback behavior. |
| cmd/entire/cli/review/picker.go | Adds fix-agent preference selection + persistence alongside review config. |
| cmd/entire/cli/review/picker_test.go | Tests persistence/preservation of ReviewFixAgent. |
| cmd/entire/cli/review/manifest.go | Introduces local review manifest structure, persistence, and lookup by session ID/prefix. |
| cmd/entire/cli/review/manifest_test.go | Tests manifest writing/lookup and fix prompt/footer behaviors. |
| cmd/entire/cli/review/fix.go | Implements --findings and --fix flows (source/finding selection + launching fix agent). |
| cmd/entire/cli/review/env.go | Adds helper to strip ENTIRE_REVIEW_* env vars when launching fix agent sessions. |
| cmd/entire/cli/review/cmd.go | Wires new flags/modes and writes manifests after single/multi-agent reviews (captures synthesis output). |
| cmd/entire/cli/review/cmd_test.go | Updates help output and multi-agent config test to reflect new flags/agent constant. |
Entire-Checkpoint: cd3fb9643dcc
Contributor
Author
|
@BugBot review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 82e472f. Configure here.
alishakawaguchi
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/entireio/cli/trails/322
Summary
entire review --findingsandentire review --fix [session-id]/--allworkflowsreview_fix_agentpreference for aggregate or multi-agent fixesVerification
go test ./cmd/entire/cli/review ./cmd/entire/cli ./cmd/entire/cli/settings -count=1mise run lintmise run testmise run buildentire review --findingsNote
Medium Risk
Adds new
entire reviewsub-modes that persist local manifests under the git directory and can spawn a follow-up agent session to apply findings, so regressions could impact review UX/CLI behavior and local state handling.Overview
Adds a local review findings workflow to
entire review: new--findingsmode to browse stored outputs and new--fix [session-id](optionally--all) mode to select sources/findings and launch a normal agent session with a targeted “fix these findings” prompt.Persists each completed review run as a local manifest (per-agent outputs plus optional multi-agent synthesized aggregate) and prints follow-up
entire review --fix ...commands after review completion; multi-agent synthesis now exposes its final result via anOnResultcallback so it can be captured into the manifest.Extends settings with a
review_fix_agentpreference (picked/saved during--editand used for aggregate/multi-agent fixes) and ensures fix runs stripENTIRE_REVIEW_*env vars before launching the fix agent.Reviewed by Cursor Bugbot for commit 82e472f. Configure here.