Skip to content

feat(review): add findings fix workflow#1145

Merged
peyton-alt merged 2 commits intomainfrom
feat/review-findings-fix
May 7, 2026
Merged

feat(review): add findings fix workflow#1145
peyton-alt merged 2 commits intomainfrom
feat/review-findings-fix

Conversation

@peyton-alt
Copy link
Copy Markdown
Contributor

@peyton-alt peyton-alt commented May 7, 2026

https://entire.io/gh/entireio/cli/trails/322

Summary

  • add local review manifests so one review session id resolves sibling agent outputs and aggregate summaries
  • add entire review --findings and entire review --fix [session-id] / --all workflows
  • add source/finding selectors plus saved review_fix_agent preference for aggregate or multi-agent fixes
  • print follow-up fix commands after review completion

Verification

  • go test ./cmd/entire/cli/review ./cmd/entire/cli ./cmd/entire/cli/settings -count=1
  • mise run lint
  • mise run test
  • mise run build
  • local smoke with PATH override: entire review --findings

Note

Medium Risk
Adds new entire review sub-modes that persist local manifests under the git directory and can spawn a follow-up agent session to apply findings, so regressions could impact review UX/CLI behavior and local state handling.

Overview
Adds a local review findings workflow to entire review: new --findings mode to browse stored outputs and new --fix [session-id] (optionally --all) mode to select sources/findings and launch a normal agent session with a targeted “fix these findings” prompt.

Persists each completed review run as a local manifest (per-agent outputs plus optional multi-agent synthesized aggregate) and prints follow-up entire review --fix ... commands after review completion; multi-agent synthesis now exposes its final result via an OnResult callback so it can be captured into the manifest.

Extends settings with a review_fix_agent preference (picked/saved during --edit and used for aggregate/multi-agent fixes) and ensures fix runs strip ENTIRE_REVIEW_* env vars before launching the fix agent.

Reviewed by Cursor Bugbot for commit 82e472f. Configure here.

Entire-Checkpoint: 76f412447fda
Copilot AI review requested due to automatic review settings May 7, 2026 21:11
@peyton-alt peyton-alt requested a review from a team as a code owner May 7, 2026 21:11
@peyton-alt
Copy link
Copy Markdown
Contributor Author

@BugBot review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a local “review findings” + “apply fixes” workflow to the entire review command by persisting per-run manifests (including sibling agent outputs and optional aggregate synthesis) and introducing new CLI entry points for browsing and applying findings, with a saved default fix-agent preference.

Changes:

  • Persist local review manifests per entire review run (agent session IDs, outputs, and optional aggregate synthesis result) and print follow-up --fix commands after completion.
  • Add entire review --findings for browsing manifests and entire review --fix [session-id] [--all] for selecting sources/findings and launching a fix agent.
  • Add review_fix_agent setting and picker/selection logic to remember the preferred agent for aggregate/multi-agent fixes.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
cmd/entire/cli/settings/settings.go Adds review_fix_agent to settings and merges it from local overrides.
cmd/entire/cli/settings/settings_test.go Extends settings round-trip test to cover review_fix_agent.
cmd/entire/cli/review/synthesis_sink.go Adds OnResult callback to capture synthesis output for manifests.
cmd/entire/cli/review/synthesis_sink_test.go Tests OnResult callback behavior.
cmd/entire/cli/review/picker.go Adds fix-agent preference selection + persistence alongside review config.
cmd/entire/cli/review/picker_test.go Tests persistence/preservation of ReviewFixAgent.
cmd/entire/cli/review/manifest.go Introduces local review manifest structure, persistence, and lookup by session ID/prefix.
cmd/entire/cli/review/manifest_test.go Tests manifest writing/lookup and fix prompt/footer behaviors.
cmd/entire/cli/review/fix.go Implements --findings and --fix flows (source/finding selection + launching fix agent).
cmd/entire/cli/review/env.go Adds helper to strip ENTIRE_REVIEW_* env vars when launching fix agent sessions.
cmd/entire/cli/review/cmd.go Wires new flags/modes and writes manifests after single/multi-agent reviews (captures synthesis output).
cmd/entire/cli/review/cmd_test.go Updates help output and multi-agent config test to reflect new flags/agent constant.

Comment thread cmd/entire/cli/review/fix.go Outdated
Comment thread cmd/entire/cli/review/fix.go Outdated
Comment thread cmd/entire/cli/review/picker.go Outdated
Comment thread cmd/entire/cli/review/manifest.go
Entire-Checkpoint: cd3fb9643dcc
@peyton-alt
Copy link
Copy Markdown
Contributor Author

@BugBot review

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 82e472f. Configure here.

@peyton-alt peyton-alt merged commit 079fec2 into main May 7, 2026
10 checks passed
@peyton-alt peyton-alt deleted the feat/review-findings-fix branch May 7, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants