Conversation
Signed-off-by: Paulo Gomes <paulo@entire.io>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses failures when creating/writing checkpoints in SHA-256 Git repositories (Fixes #1133) by upgrading the go-git stack to a version that supports SHA-256 object formats and adding an integration test that exercises the enable + first-checkpoint path in a SHA-256 repo.
Changes:
- Bump
github.com/go-git/go-git/v6(and related go-git deps) to pick up SHA-256 repository support. - Update code to the new go-git worktree filesystem accessor API (
Filesystem().Root()). - Add an integration test that initializes a SHA-256 repo and verifies the first checkpoint is created and condensed successfully.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates go-git/go-billy versions and bumps indirect sha1cd. |
| go.sum | Syncs checksums for updated go-git/go-billy/go-git-fixtures and sha1cd. |
| cmd/entire/cli/strategy/metadata_reconcile.go | Adjusts worktree filesystem root access for updated go-git API. |
| cmd/entire/cli/strategy/manual_commit_hooks.go | Adjusts worktree filesystem root access for updated go-git API. |
| cmd/entire/cli/strategy/content_overlap.go | Adjusts worktree filesystem root access for updated go-git API. |
| cmd/entire/cli/review/scope.go | Adjusts worktree filesystem root access for updated go-git API. |
| cmd/entire/cli/reset_test.go | Updates tests for updated go-git API (Filesystem().Root()). |
| cmd/entire/cli/migrate.go | Adjusts worktree filesystem root access for updated go-git API. |
| cmd/entire/cli/migrate_test.go | Updates tests to use Filesystem().Root() for chdir. |
| cmd/entire/cli/integration_test/sha256_repo_test.go | New integration test covering enable + first checkpoint in a SHA-256 repo. |
| cmd/entire/cli/explain_test.go | Updates tests for updated go-git API (Filesystem().Root()). |
| cmd/entire/cli/clean_test.go | Updates tests for updated go-git API (Filesystem().Root() / Filesystem().MkdirAll). |
| cmd/entire/cli/checkpoint/v2_read_test.go | Updates test for updated go-git API (Filesystem().Root()). |
| cmd/entire/cli/checkpoint/temporary.go | Updates worktree root discovery for git subprocesses with updated go-git API. |
| cmd/entire/cli/checkpoint/checkpoint_test.go | Updates tests for updated go-git API (Filesystem().Root()). |
Signed-off-by: Paulo Gomes <paulo@entire.io> Entire-Checkpoint: 30df7fcff4f5
Signed-off-by: Paulo Gomes <paulo@entire.io>
Signed-off-by: Paulo Gomes <paulo@entire.io>
Soph
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/entireio/cli/trails/325
Fixes #1133.
Note
Medium Risk
Upgrades core
go-gitdependencies and adjusts worktree filesystem accessors across checkpoint/clean/migrate/review code paths, which could subtly affect repository path resolution. Adds an integration test to catch regressions in SHA-256 object-format repos, reducing but not eliminating risk.Overview
Ensures the CLI can create and persist checkpoints in SHA-256 object-format git repositories by adding an integration test that runs
enable, creates a first checkpoint via hooks, and asserts SHA-256-length object IDs and metadata branch updates.Updates
go-git/go-billy(andsha1cd) and refactors various call sites to use the newerWorktree.Filesystem()API (replacing directFilesystem.Root()/Filesystem.MkdirAllaccess) across checkpointing, cleaning, migration, and review scope logic.Reviewed by Cursor Bugbot for commit f50e6e9. Configure here.