Skip to content

Clarify checkpoints v2 rotation docs#1179

Merged
pfleidi merged 4 commits into
mainfrom
fix/checkpoints-v2-rotation-logic-docs
May 11, 2026
Merged

Clarify checkpoints v2 rotation docs#1179
pfleidi merged 4 commits into
mainfrom
fix/checkpoints-v2-rotation-logic-docs

Conversation

@pfleidi
Copy link
Copy Markdown
Contributor

@pfleidi pfleidi commented May 11, 2026

https://entire.io/gh/entireio/cli/trails/353

What

Documents how checkpoints v2 raw-transcript generations rotate, publish pending archives, and recover from remote rotation conflicts.

How

  • Adds a checkpoints v2 rotation architecture note covering ref layout, local rotation, pre-push publication, conflict recovery, cleanup, and failure windows.
  • Clarifies that v2 full refs store chunked raw_transcript files and that pre-push validates the newest queued reset root before publishing queued archive refs together.

Verification

  • mise run build
  • mise run lint
  • mise run test

Note

Low Risk
Documentation-only changes plus a clarifying code comment; no functional behavior changes.

Overview
Adds a new architecture note docs/architecture/checkpoints-v2-rotation.md describing how checkpoints v2 rotates /full/current into archived /full/<N> refs, how pending publication markers are used, and how pre-push publishes archives and safely resets remote /full/current.

Clarifies the rotation comment in v2_generation.go to reflect that pre-push drops stale queued resets until the newest reset root is present in local /full/current history, then publishes queued archive refs together.

Reviewed by Cursor Bugbot for commit 7026174. Configure here.

@pfleidi pfleidi requested a review from a team as a code owner May 11, 2026 21:11
Copilot AI review requested due to automatic review settings May 11, 2026 21:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an architecture note documenting how checkpoints v2 rotates /full/current into archived /full/<N> generations, how pending rotation publications are recorded locally, and how the pre-push path publishes archives + safely resets remote /full/current (including remote-rotation conflict recovery). Also updates an inline code comment to reflect the current pre-push stale-handoff dropping + queued-archive publication behavior.

Changes:

  • Add docs/architecture/checkpoints-v2-rotation.md describing v2 full-transcript generation layout, rotation, pending publication markers, pre-push publication, conflict recovery, and cleanup/failure windows.
  • Update rotation code comment to match current pre-push behavior around stale reset handoffs and publishing queued archives.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
docs/architecture/checkpoints-v2-rotation.md New architecture documentation for v2 full generation rotation + publication and recovery behavior.
cmd/entire/cli/checkpoint/v2_generation.go Comment update describing how pre-push handles stale reset handoffs and queued archive publications.

Comment thread docs/architecture/checkpoints-v2-rotation.md Outdated
Comment thread docs/architecture/checkpoints-v2-rotation.md Outdated
computermode
computermode previously approved these changes May 11, 2026
@pfleidi
Copy link
Copy Markdown
Contributor Author

pfleidi commented May 11, 2026

Bugbot run

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 7026174. Configure here.

pfleidi added 2 commits May 11, 2026 14:23
Correct the User A example to respect the 100-checkpoint rotation threshold,
expand the pre-push step list with the idempotent short-circuit and the
ancestor-check gate, clarify that the force-with-lease anchor is the remote
hash just read (not the marker's previous_full_current_hash), note that the
remote rotation conflict recovery path does mutate an archived ref, and
correct the cleanup description to cover local ref deletion as well.

Entire-Checkpoint: c6ba612414f1
Entire-Checkpoint: 453d4bb44f01
@pfleidi pfleidi merged commit dcf744f into main May 11, 2026
9 checks passed
@pfleidi pfleidi deleted the fix/checkpoints-v2-rotation-logic-docs branch May 11, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants