test: avoid external agent type collision in rewind test#1217
Merged
Conversation
The dynamic ResolveAgentForRewind test used a fake agent with type "Kiro" to simulate external agent registration. On machines that have a real entire-agent-kiro on PATH, earlier external discovery tests can register that real agent into the process-global registry with the same type. Because GetByAgentType scans a map, the rewind test could resolve the host agent instead of the test fixture and fail depending on package test ordering and map iteration. Rename the test fixture to a synthetic Entire-specific name and type so it still exercises runtime external-agent registration without colliding with installed local plugins. Verification: mise run check Entire-Checkpoint: 0d01bc231758
Contributor
There was a problem hiding this comment.
Pull request overview
Renames a test fixture's synthetic agent name/type to avoid collisions with a real entire-agent-kiro plugin that may be installed on the host, which could cause flaky resolution in TestResolveAgentForRewind due to map iteration order in the global agent registry.
Changes:
- Rename test agent name from
test-external-kirototest-external-rewind-agent. - Rename test agent type from
KirotoEntire Test External Rewind Agentto prevent registry collisions.
pfleidi
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/entireio/cli/trails/381
The dynamic ResolveAgentForRewind test used a fake agent with type "Kiro" to simulate external agent registration. On machines that have a real entire-agent-kiro on PATH, earlier external discovery tests can register that real agent into the process-global registry with the same type. Because GetByAgentType scans a map, the rewind test could resolve the host agent instead of the test fixture and fail depending on package test ordering and map iteration.
Rename the test fixture to a synthetic Entire-specific name and type so it still exercises runtime external-agent registration without colliding with installed local plugins.
Note
Low Risk
Low risk: test-only rename to avoid collisions with real installed external agents; no production logic changes.
Overview
Makes the
ResolveAgentForRewinddynamic-registration test deterministic by changing the fake external agent’sname/typefrom a potentially real value (e.g.Kiro) to a unique synthetic identifier, avoiding collisions with any externally discovered/installed agents in the global registry.Reviewed by Cursor Bugbot for commit ace97f7. Configure here.