Skip to content

Add agent-safe review findings fallback#1598

Merged
peyton-alt merged 5 commits into
mainfrom
agent-output-fallback-for-review
Jul 2, 2026
Merged

Add agent-safe review findings fallback#1598
peyton-alt merged 5 commits into
mainfrom
agent-output-fallback-for-review

Conversation

@pfleidi

@pfleidi pfleidi commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

https://entire.io/gh/entireio/cli/trails/724

Why

entire review --findings needed an agent-safe way to reach full saved review
findings. The previous non-interactive fallback could show that findings
existed, but agents still needed the terminal picker to reveal the full detail.

What changed

The findings list now prints stable handles with direct view: commands, and
entire review --findings <handle> renders the full saved findings without a
TUI. Non-interactive profile editing now refuses with scripted alternatives
instead of requiring a picker.

Usage examples

entire review --findings

prints saved findings with commands such as:

view: entire review --findings 'claude-session'

Then:

entire review --findings claude-session

prints the full saved review detail.

Decisions made during development

The fallback stays plain text instead of forcing JSON everywhere, matching the
agent-safe CLI guidance that complete human-readable output is acceptable.
Handles prefer saved source session IDs and fall back to a timestamp handle when
no session ID is available.

Technical tradeoffs

Timestamp fallback handles can theoretically collide, so the command reports an
ambiguous handle instead of guessing. Generated view: commands quote handles
for copy-paste safety while lookup still accepts the raw argument value.


Note

Low Risk
CLI-only review findings browsing and argument routing; no auth, persistence format changes beyond shared timestamp helper for manifest filenames.

Overview
entire review --findings now supports an optional handle so agents and scripts can open a saved run without the TUI. entire review --findings <handle> prints full reviewer output and aggregate summary; handles are source session IDs, with a UTC timestamp fallback when there is no session ID. Ambiguous handles fail explicitly instead of picking a manifest.

The non-interactive findings list and post-review footer include copy-paste view: commands with shell-quoted handles. Unknown handles error with a list of available view: commands. With --findings, a positional argument is treated as the handle (so --profile can be combined without conflicting with “profile as positional”).

entire review --edit in a non-interactive environment now exits with pointers to --list and --configure --set-* instead of requiring the picker.

Reviewed by Cursor Bugbot for commit 71171b0. Configure here.

pfleidi added 3 commits July 1, 2026 15:04
Let non-interactive review findings output print stable handles and direct view commands.

Also refuse review profile editing without an interactive terminal and point callers at scripted configuration commands.

Entire-Checkpoint: 80df055b41a6
Keep --profile separate from findings handles, fail requested handles when no findings exist, and quote generated view commands for copy-paste safety.

Add focused regressions for the non-interactive findings paths.

Entire-Checkpoint: 76341f0fe352
Copilot AI review requested due to automatic review settings July 1, 2026 22:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes entire review --findings fully usable in non-interactive/agent contexts by emitting stable “handle” references and enabling direct, non-TUI rendering of saved findings via entire review --findings <handle>. It also hard-fails --edit when no interactive terminal is available, pointing users to scripted alternatives.

Changes:

  • Add handle-based routing for --findings so entire review --findings <handle> prints full saved review detail without a picker.
  • Improve non-interactive output by printing copy/paste view: commands (with shell-quoted handles) in findings lists and the completion footer.
  • Refuse non-interactive --edit with actionable non-TUI alternatives (--list, --configure --set-*).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
cmd/entire/cli/review/fix.go Implements handle lookup, detail rendering, and generation of shell-quoted view: commands for findings browsing.
cmd/entire/cli/review/cmd.go Adjusts argument routing so the optional positional arg becomes a findings handle when --findings is set; adds non-interactive refusal for --edit.
cmd/entire/cli/review/manifest_test.go Adds/updates tests for quoted handle commands, timestamp fallback handles, and handle-based detail rendering.
cmd/entire/cli/review/cmd_test.go Adds a regression test ensuring --edit fails non-interactively with scripted alternatives.

Comment thread cmd/entire/cli/review/fix.go
Print quoted view commands in the available-findings error path so copied handles are shell-safe.

Reuse the review handle helpers for manifest naming and handle deduplication so list and detail paths stay consistent.

Entire-Checkpoint: 4b50b9a535cc
@pfleidi

pfleidi commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Bugbot run

@pfleidi pfleidi marked this pull request as ready for review July 1, 2026 23:21
@pfleidi pfleidi requested a review from a team as a code owner July 1, 2026 23:21

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 71171b0. Configure here.

Prefer timestamp handles in generated review findings commands when session handles may be shared across saved manifests.

This keeps advertised view commands usable even after re-reviewing the same source session.

Entire-Checkpoint: ed909b22b352
@peyton-alt peyton-alt merged commit 0aa9871 into main Jul 2, 2026
9 checks passed
@peyton-alt peyton-alt deleted the agent-output-fallback-for-review branch July 2, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants