Skip to content

Hide completion command in root.go#21

Merged
Soph merged 3 commits intomainfrom
hide-completion-command
Jan 12, 2026
Merged

Hide completion command in root.go#21
Soph merged 3 commits intomainfrom
hide-completion-command

Conversation

@peyton-alt
Copy link
Contributor

@peyton-alt peyton-alt commented Jan 8, 2026

Added lines in NewRootCmd hides function in entire and entire help.

entire completion works as expected, e.g:
entire completion zsh -> display shell code
source <(entire completion zsh) -> to activate
tabbing works to select entire commands

Copy link
Collaborator

@Soph Soph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more ask: Can you add a "--setup-shell" that can be added when you do enable via a none interactive command call? Default should be "false" and then when you add the flag it gets added 🤔

@entireio entireio deleted a comment from Soph Jan 9, 2026
@gtrrz-victor
Copy link
Contributor

Do we need "--setup-shell" flag ? brew install should take care of it: https://github.com/entirehq/homebrew-entire/blob/9bbbb5a6771eba89be71c8e9a86cee40fbf436f6/Formula/entire.rb#L17

@Soph
Copy link
Collaborator

Soph commented Jan 12, 2026

@gtrrz-victor just making sure, since I just had issues understanding my own comment: I meant entire enable should get a --setup-shell command.

But ok, if we just do it on installation with homebrew and any other installation method we support, then yeah, we might not need it. Ok, let's ignore this. Can add it when we need it.

@Soph Soph merged commit b0fa8d5 into main Jan 12, 2026
3 checks passed
@Soph Soph deleted the hide-completion-command branch January 12, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants