Conversation
Soph
reviewed
Jan 9, 2026
Collaborator
Soph
left a comment
There was a problem hiding this comment.
One more ask: Can you add a "--setup-shell" that can be added when you do enable via a none interactive command call? Default should be "false" and then when you add the flag it gets added 🤔
Soph
approved these changes
Jan 9, 2026
Closed
Contributor
|
Do we need "--setup-shell" flag ? |
Collaborator
|
@gtrrz-victor just making sure, since I just had issues understanding my own comment: I meant But ok, if we just do it on installation with homebrew and any other installation method we support, then yeah, we might not need it. Ok, let's ignore this. Can add it when we need it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added lines in NewRootCmd hides function in entire and entire help.
entire completion works as expected, e.g:
entire completion zsh -> display shell code
source <(entire completion zsh) -> to activate
tabbing works to select entire commands