Agent integration: Pi coding agent #232
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| package pi | ||
|
|
||
| import ( | ||
| "context" | ||
| "path/filepath" | ||
|
|
||
| "github.com/entireio/cli/cmd/entire/cli/agent" | ||
| "github.com/entireio/cli/cmd/entire/cli/session" | ||
| ) | ||
|
|
||
| type PiAgent struct{} | ||
|
|
||
| func NewPiAgent() *PiAgent { | ||
| return &PiAgent{} | ||
| } | ||
|
|
||
| func (a *PiAgent) Name() string { | ||
| return "Pi" | ||
| } | ||
|
|
||
| func (a *PiAgent) Detect(ctx context.Context, repoRoot string) (bool, error) { | ||
| // Pi usually has a ~/.pi directory or project local .pi | ||
| // Simplified detection for skeleton | ||
| return true, nil | ||
| } | ||
|
|
||
| func (a *PiAgent) InstallHooks(ctx context.Context, repoRoot string) error { | ||
| return nil | ||
| } | ||
|
|
||
| func (a *PiAgent) UninstallHooks(ctx context.Context, repoRoot string) error { | ||
| return nil | ||
| } | ||
|
|
||
| func (a *PiAgent) ReadSession(ctx context.Context, sessionID string) (*agent.SessionMetadata, error) { | ||
| return &agent.SessionMetadata{ | ||
| SessionID: sessionID, | ||
| }, nil | ||
| } | ||
|
There was a problem hiding this comment. PiAgent methods don't match the Agent interfaceHigh Severity
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Detect unconditionally returns true for all repos
Medium Severity
The
Detectmethod (intended asDetectPresence) always returnstrue, nilregardless of whether the Pi agent is actually installed. The comment mentions checking for~/.pior.pidirectories, but no such check is performed. In theDetect()function inregistry.go, all registered agents are iterated and the first one whoseDetectPresencereturnstrueis selected — so an always-true implementation would cause Pi to be incorrectly auto-detected as the active agent in every repository.