Skip to content

Comments

adding more integration / e2e tests for different scenarios#390

Merged
gtrrz-victor merged 2 commits intomainfrom
soph/more-test-coverage
Feb 18, 2026
Merged

adding more integration / e2e tests for different scenarios#390
gtrrz-victor merged 2 commits intomainfrom
soph/more-test-coverage

Conversation

@Soph
Copy link
Collaborator

@Soph Soph commented Feb 17, 2026

Adding more integration / e2e tests to make both test the same scenarios and added some more.

Copilot AI review requested due to automatic review settings February 17, 2026 16:25
@cursor
Copy link

cursor bot commented Feb 17, 2026

PR Summary

Low Risk
Test-only changes that expand coverage around checkpoint condensation/carry-forward and git-hook behavior; low risk to production code but may increase CI runtime/flakiness due to more scenarios.

Overview
Expands checkpoint workflow coverage in both E2E and integration suites, focusing on carry-forward edge cases and ensuring checkpoint trailers always correspond to metadata condensed onto entire/checkpoints/v1.

Adds new scenarios for ENDED sessions (commits after agent exit / session-end hook), deleted files committed via git rm, agent mid-turn commits followed by user committing remaining files, and opt-out behavior when users remove the Entire-Checkpoint: trailer. Multiple existing E2E scenarios now also assert that no unexpected entire/* shadow branches remain once all touched files are committed (with noted exceptions for still-stashed files).

Enhances test harnesses with helpers to git rm, commit already-staged changes while still running prepare-commit-msg/post-commit hooks (GitCommitStagedWithShadowHooks), remove trailers before committing (GitCommitWithTrailerRemoved), and simulate the session-end hook (SimulateSessionEnd).

Written by Cursor Bugbot for commit f26d403. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive integration and end-to-end tests for different checkpoint and file management scenarios in the shadow branching system. The tests focus on edge cases like session ending, file deletions, carry-forward behavior, and trailer removal.

Changes:

  • Added helper methods for git operations (GitRm, GitCommitStagedWithShadowHooks, GitCommitWithTrailerRemoved)
  • Added SimulateSessionEnd hook simulation for testing ENDED session phase
  • Added three new integration tests covering ended sessions, deleted files, and modified file carry-forward scenarios
  • Added five new E2E tests validating checkpoint workflows for ended sessions, file deletions, mid-turn commits, trailer removal, and session depletion

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
cmd/entire/cli/integration_test/testenv.go Added git operation helpers (GitRm, GitCommitStagedWithShadowHooks) for testing file deletions and staged commits with hooks
cmd/entire/cli/integration_test/hooks.go Added SimulateSessionEnd method to test session-end hook behavior
cmd/entire/cli/integration_test/deferred_finalization_test.go Added integration tests for ended sessions, deleted files, and carry-forward with modified files
cmd/entire/cli/e2e_test/testenv.go Added git operation helpers (GitRm, GitCommitStagedWithShadowHooks, GitCommitWithTrailerRemoved) for E2E testing
cmd/entire/cli/e2e_test/scenario_checkpoint_workflows_test.go Added E2E tests for various checkpoint scenarios and shadow branch cleanup validations

Soph added 2 commits February 18, 2026 10:36
Entire-Checkpoint: 607310163725
@gtrrz-victor gtrrz-victor marked this pull request as ready for review February 17, 2026 23:38
@gtrrz-victor gtrrz-victor requested a review from a team as a code owner February 17, 2026 23:38
@gtrrz-victor gtrrz-victor force-pushed the soph/more-test-coverage branch from 489da9a to 8a8775b Compare February 17, 2026 23:38
@gtrrz-victor gtrrz-victor merged commit 401c1c8 into main Feb 18, 2026
3 checks passed
@gtrrz-victor gtrrz-victor deleted the soph/more-test-coverage branch February 18, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants