adding more integration / e2e tests for different scenarios#390
adding more integration / e2e tests for different scenarios#390gtrrz-victor merged 2 commits intomainfrom
Conversation
PR SummaryLow Risk Overview Adds new scenarios for ENDED sessions (commits after agent exit / session-end hook), deleted files committed via Enhances test harnesses with helpers to Written by Cursor Bugbot for commit f26d403. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive integration and end-to-end tests for different checkpoint and file management scenarios in the shadow branching system. The tests focus on edge cases like session ending, file deletions, carry-forward behavior, and trailer removal.
Changes:
- Added helper methods for git operations (GitRm, GitCommitStagedWithShadowHooks, GitCommitWithTrailerRemoved)
- Added SimulateSessionEnd hook simulation for testing ENDED session phase
- Added three new integration tests covering ended sessions, deleted files, and modified file carry-forward scenarios
- Added five new E2E tests validating checkpoint workflows for ended sessions, file deletions, mid-turn commits, trailer removal, and session depletion
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/entire/cli/integration_test/testenv.go | Added git operation helpers (GitRm, GitCommitStagedWithShadowHooks) for testing file deletions and staged commits with hooks |
| cmd/entire/cli/integration_test/hooks.go | Added SimulateSessionEnd method to test session-end hook behavior |
| cmd/entire/cli/integration_test/deferred_finalization_test.go | Added integration tests for ended sessions, deleted files, and carry-forward with modified files |
| cmd/entire/cli/e2e_test/testenv.go | Added git operation helpers (GitRm, GitCommitStagedWithShadowHooks, GitCommitWithTrailerRemoved) for E2E testing |
| cmd/entire/cli/e2e_test/scenario_checkpoint_workflows_test.go | Added E2E tests for various checkpoint scenarios and shadow branch cleanup validations |
Entire-Checkpoint: 23c12b02e45c
Entire-Checkpoint: 607310163725
489da9a to
8a8775b
Compare
Adding more integration / e2e tests to make both test the same scenarios and added some more.