Skip to content

telemetry disable by default#54

Merged
Soph merged 5 commits intomainfrom
gtrrz-victor/missing-telemetry-config-means-disable
Jan 20, 2026
Merged

telemetry disable by default#54
Soph merged 5 commits intomainfrom
gtrrz-victor/missing-telemetry-config-means-disable

Conversation

@gtrrz-victor
Copy link
Contributor

Summary

  • Change telemetry to be disabled by default when not explicitly configured
  • Previously, nil (unconfigured) telemetry setting defaulted to enabled; now it defaults to disabled

@Soph
Copy link
Collaborator

Soph commented Jan 19, 2026

I wonder if we invert the flag now 🤔 Like you can't enable telemetry now if you use only params (-> none interactive) but you can disable it, but it's off by default.

@khaong khaong requested a review from a team as a code owner January 19, 2026 23:31
Entire-Checkpoint: ea59bf8d9e0b
2. adds extra fields to telemetry like: agent,strategy,isEntireEnabled
Entire-Checkpoint: eacf5c355b86
@gtrrz-victor
Copy link
Contributor Author

gtrrz-victor commented Jan 20, 2026

I added some extra changes.

  1. we now collect the selected strategy, agent (auto if empty) and if entire is enabled on every event (read from settings)
image
  1. we initialise telemetry client at postrunhook, so we get the latest telemetry configuration value ( I will explain in depth next comment )
  2. flag to enable/disable telemetry now is: entire enable --telemetry || entire enable --telemetry false

@gtrrz-victor
Copy link
Contributor Author

I wonder if we invert the flag now 🤔 Like you can't enable telemetry now if you use only params (-> none interactive) but you can disable it, but it's off by default.

Let me explain how the current flow looks like.
Scenario 1:

  • No .entire folder found
  • Run entire help
  • "entire help" telemetry is NOT sent

Scenario 2:

  • No .entire folder found
  • Run entire enable (interactive)
  • Prompt asks if user wants to share telemetry (user answers N)
  • Settings updated to {"telemetry": false}
  • "entire enable" telemetry is NOT sent
  • Run entire enable (interactive) again
  • Prompt doesn't ask about telemetry — settings already has {"telemetry": false}
  • "entire enable" telemetry is NOT sent

Scenario 3:

  • No .entire folder found
  • Run entire enable (interactive)
  • Prompt asks if user wants to share telemetry (user answers Y)
  • Settings updated to {"telemetry": true}
  • "entire enable" telemetry is sent
  • Run entire enable (interactive) again
  • Prompt doesn't ask about telemetry — settings already has {"telemetry": true}
  • "entire enable" telemetry is sent

Scenario 4 (Same flow as Scenarios 1 and 2):

  • .entire folder found but settings doesn't have the "telemetry" attribute

In other words: if the settings file doesn't have telemetry or it's set to false, telemetry is not sent.
When running "entire enable", if settings doesn't have the telemetry attribute, it asks the user if they want to opt in.

@Soph Soph merged commit 639caf9 into main Jan 20, 2026
3 checks passed
@Soph Soph deleted the gtrrz-victor/missing-telemetry-config-means-disable branch January 20, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants