Fetch remote entire/sessions branch when doing resume#59
Conversation
Entire-Checkpoint: a200dee20660
Entire-Checkpoint: 5ac45bc32212
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| // Now resume the session with the fetched metadata | ||
| return resumeSession(metadata.SessionID, checkpointID, false) |
There was a problem hiding this comment.
The force parameter should be propagated from the caller instead of being hard-coded to false. The checkRemoteMetadata function is called from resumeFromCurrentBranch which has access to the force flag. When users run resume --force, they expect to skip all confirmation prompts, but this hard-coded false would still trigger prompts during session restoration. Consider adding a force parameter to checkRemoteMetadata and passing it through to resumeSession.
|
I hit this error while trying these changes: Then I found that this is a known issue with go-git: go-git/go-git#411 That fixed the go-git error. |
Right now when doing
entire resume soph/track-session-positionthen it might tell you that you need to fetchentire/sessionsmanually. Let's just do this automatically.Also if we encounter an error during
resumelet's print the error only and not also the usage of the command which wouldn't be helpful if the error is not related to passed in params.