Skip to content

Improved entire enable messaging#6

Merged
Soph merged 8 commits intomainfrom
soph/improve-enable
Jan 6, 2026
Merged

Improved entire enable messaging#6
Soph merged 8 commits intomainfrom
soph/improve-enable

Conversation

@Soph
Copy link
Copy Markdown
Collaborator

@Soph Soph commented Jan 5, 2026 •
edited
Loading

Before (main branch)

  $ entire enable --strategy manual-commit

  ✓ Local settings saved (.entire/settings.local.json)

  ✓ Enabled (manual-commit)

After (this branch)

  $ entire enable --strategy manual-commit
  ✓ Claude Code hooks installed
  ✓ Local settings saved (.entire/settings.local.json)
  ✓ Git hooks installed

  ✓ manual-commit strategy enabled

When running again (everything already set up):

  $ entire enable --strategy manual-commit
  ✓ Claude Code hooks verified
  ✓ Local settings saved (.entire/settings.local.json)
  ✓ Git hooks verified
  ✓ Created orphan branch 'entire/sessions' for session metadata

  ✓ manual-commit strategy enabled

For auto-commit strategy:

  $ entire enable --strategy auto-commit
  ✓ Claude Code hooks installed
  ✓ Local settings saved (.entire/settings.local.json)
  ✓ Git hooks installed
  ✓ Created orphan branch 'entire/sessions' for session metadata

  ✓ auto-commit strategy enabled

@Soph
slightly more verbose enable
24cb7a3 
Entire-Checkpoint: 3724a646375c
@Soph Soph requested a review from dipree January 5, 2026 18:56
Soph added 7 commits January 6, 2026 12:35
@Soph
more informative output depending on state when enabling
b10dfb8 
Entire-Checkpoint: 2a29469db94c
@Soph
when already enabled, ask if repo or local settings file should be up…
f8f1821 
…dated

Entire-Checkpoint: 2a29469db94c
@Soph
adding tests
93d5ac4 
Entire-Checkpoint: 2a29469db94c
@Soph
make it more clear what file is changed / updated
27dad89 
Entire-Checkpoint: 35762f1bcfdb
@Soph
show only "✓ manual-commit strategy enabled"
5f136a8 
Entire-Checkpoint: e140526ef3de
@Soph
fixed tests
52e38ba 
Entire-Checkpoint: 0382579310fc
@Soph
show "✓ Created orphan branch 'entire/sessions' for session metadata"…
8cbc26c 
… for both strategies

Entire-Checkpoint: 74af160f6f80
@Soph Soph merged commit e5914c3 into main Jan 6, 2026
3 checks passed
@Soph Soph deleted the soph/improve-enable branch January 7, 2026 16:19
khaong added a commit that referenced this pull request Jan 27, 2026
@khaong @claude
fix: validate agent UUID and generate safe fallback
446f931 
- Add ValidateAgentUUID to validation package using google/uuid
- GetOrCreateEntireSessionID now validates UUID format
- Invalid UUIDs generate a random safe UUID instead of using untrusted input
- Log warning with original input and generated ID when fallback occurs
- Add thread-safety documentation to GetOrCreateEntireSessionID
- Update tests to use valid UUIDs
- Add test for invalid UUID fallback behavior

Addresses Copilot review comments #5 and #6.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Entire-Checkpoint: 47672e4ef20f
khaong added a commit that referenced this pull request Jan 27, 2026
@khaong @claude
fix: validate agent session ID for path safety
31882d4 
- Add ValidateAgentSessionID to validation package (path-safe check, not UUID)
- GetOrCreateEntireSessionID validates input and logs warning if invalid
- Add thread-safety documentation to GetOrCreateEntireSessionID
- Rename parameter from agentSessionUUID to agentSessionID for clarity
- Add tests for ValidateAgentSessionID

Allows test IDs like "test-session-1" while preventing path traversal.
Addresses Copilot review comments #5 and #6.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@Soph Soph mentioned this pull request May 8, 2026
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dipree dipree dipree approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Soph @dipree