Skip to content

Use cleaner base URL in login output#728

Merged
Soph merged 1 commit intofeat/device-auth-loginfrom
feat/login-cleaner-url
Mar 19, 2026
Merged

Use cleaner base URL in login output#728
Soph merged 1 commit intofeat/device-auth-loginfrom
feat/login-cleaner-url

Conversation

@dipree
Copy link
Contributor

@dipree dipree commented Mar 19, 2026

Summary

  • Prefer verification_uri (base URL) over verification_uri_complete (URL with code query param) in entire login output
  • The device code is already printed on its own line, so repeating it in the URL is redundant noise

Before

Device code: RB3X-56HU
Press Enter to open https://entire.io/cli/auth?code=RB3X-56HU in your browser...

After

Device code: RB3X-56HU
Press Enter to open https://entire.io/cli/auth in your browser...

Test plan

  • mise run fmt && mise run lint passes
  • mise run test:ci passes (unit + integration + canary)
  • Manual test: run entire login and verify the URL no longer includes the code query param

Note: Depends on #723 — merge that first.

🤖 Generated with Claude Code


Note

Low Risk
Low risk: only changes which verification URL is printed/opened during device login, with a simple fallback if the preferred field is empty.

Overview
Updates entire login to prefer verification_uri (base URL) over verification_uri_complete when displaying/opening the approval link, falling back to the complete URL only when the base URL is missing. This reduces redundant noise since the device code is already printed separately.

Written by Cursor Bugbot for commit 0e016d6. Configure here.

The device code is already printed on its own line, so embedding it in
the URL as a query parameter is redundant. Use the cleaner base URL.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: a47ac4352190
Copilot AI review requested due to automatic review settings March 19, 2026 07:54
@dipree dipree requested a review from a team as a code owner March 19, 2026 07:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the entire login UX to prefer a cleaner “base” verification URL (without embedding the device code) when presenting the approval link, reducing redundant noise in user-facing output.

Changes:

  • Prefer verification_uri over verification_uri_complete when selecting the approval URL.
  • Keep a fallback to the other field when the preferred URL is missing.

@Soph
Copy link
Collaborator

Soph commented Mar 19, 2026

The device code is already printed on its own line, so repeating it in the URL is redundant noise

Is it? I mean it would be just one copy&paste but I also feel this makes it more secure that you can't easily drop someone the url and log him in instead of you. So I think it's good that the code can't be part of the URL at all

@Soph Soph merged commit f7be543 into feat/device-auth-login Mar 19, 2026
8 checks passed
@Soph Soph deleted the feat/login-cleaner-url branch March 19, 2026 14:34
@Soph Soph restored the feat/login-cleaner-url branch March 19, 2026 14:36
matthiaswenz added a commit that referenced this pull request Mar 20, 2026
- Show clean verification_uri to the user, but open
  verification_uri_complete (with code pre-filled) in the browser
- Make waitForEnter context-aware so Ctrl+C exits cleanly instead of
  leaving the process stuck on a blocking tty read

Fixes regression from #728 where the browser-opened URL lost the
auth code parameter.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: 1518a16ea037
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants