Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds interactive “manage agents” behavior to entire configure so users can both add and remove agent hooks in a single multi-select flow.
Changes:
- Replaces the previous “add agents” flow with a “manage agents” flow that supports uninstalling hooks when agents are deselected.
- Introduces
applyAgentChangesto compute added/removed sets and apply hook installs/uninstalls, plus a summary output. - Adds tests covering deselect/remove behaviors, deselect-all guidance, no-op selection, add+remove in one run, and
--removeflag regression.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
cmd/entire/cli/setup.go |
Implements interactive agent add/remove management and applies hook install/uninstall changes with user-facing summaries. |
cmd/entire/cli/setup_test.go |
Adds test coverage for interactive manage-agent scenarios and verifies configure --remove still works. |
Contributor
Author
|
@BugBot review |
Rename runAddAgents to runManageAgents and allow users to deselect installed agents in the interactive multi-select. Deselecting removes hooks; the summary now shows both added and removed agents. - Remove validation that blocked deselection of installed agents - Remove "all agents installed" early exit (users may want to remove) - Extract applyAgentChanges helper for post-selection processing - Add selectFn parameter for testability - Update command description to reflect add/remove capability Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 5db1ec6fe024
Remove the "at least one agent" constraint from the configure multi-select. When all agents are deselected, remove all hooks and show guidance on how to re-add agents. Also adds tests for the full manage agents flow: deselect removes, deselect all with guidance, no changes, add+remove, --remove regression. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Entire-Checkpoint: d8018fc09ed9
Address PR review feedback: don't silently skip agent.Get() failures when computing agents to remove. Return errors instead of continuing, so users aren't told "All agents have been removed" when some failed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 63e9ba99d0bd
Address review feedback: - Collect errors in applyAgentChanges instead of returning on first failure, so partial successes are reported to the user - Log warning when installed agent unexpectedly lacks hook support - Surface external_agents setting save errors in error collection - Verify Gemini hooks on disk in AddAndRemove test Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Entire-Checkpoint: ba3cd61139fd
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
peyton-alt
force-pushed
the
configure-remove-agent
branch
from
f4e028b to
c4b4f7e
Compare
When no agents are installed and user confirms empty selection, show "No changes made." instead of "All agents have been removed." Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 7778bc92e289
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Moderate risk because
entire configurenow uninstalls hooks for deselected agents and supports removing all agents, which directly modifies repo hook/config files and could leave partial state on error.Overview
entire configurere-runs now open a Manage agents prompt that supports both adding and removing agents; deselecting an installed agent uninstalls its hooks, and selecting nothing removes all agent hooks and prints guidance to re-add via--agent.Hook changes are applied via a new
applyAgentChangesflow that computes added/removed sets, performs installs/uninstalls with aggregated errors, and prints a success summary; newly added external agents still auto-enableexternal_agents. Tests were expanded to cover deselect/removal scenarios (including deselect-all, no-op selections, add+remove) and to ensureconfigure --removecontinues to work.Written by Cursor Bugbot for commit f4e028b. Configure here.