Skip to content

Do not truncate Logs when storing#89

Merged
khaong merged 4 commits intomainfrom
soph/do-not-truncate
Jan 23, 2026
Merged

Do not truncate Logs when storing#89
khaong merged 4 commits intomainfrom
soph/do-not-truncate

Conversation

@Soph
Copy link
Collaborator

@Soph Soph commented Jan 22, 2026

This removes the logic that would only commit the new log lines since last checkpoint if a session was continued and produced multiple checkpoints.

@Soph Soph requested a review from a team as a code owner January 22, 2026 17:11
@Soph Soph force-pushed the soph/do-not-truncate branch from 0546bcf to 5c4c298 Compare January 22, 2026 19:38
Soph added 2 commits January 22, 2026 20:48
Entire-Checkpoint: 5e5207b424e2
Entire-Checkpoint: 44bae9eebc2e
@Soph Soph force-pushed the soph/do-not-truncate branch from 5c4c298 to ab8f1a4 Compare January 22, 2026 19:55
Base automatically changed from soph/refactor-trailer-checkpoint-id to main January 23, 2026 00:40
Copilot AI review requested due to automatic review settings January 23, 2026 00:57
Remove stale references to incremental/startLine behavior now that
transcripts are stored in full.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Entire-Checkpoint: 7169f9710768
@khaong khaong force-pushed the soph/do-not-truncate branch from 25f4652 to 70839fc Compare January 23, 2026 00:58
@khaong khaong merged commit bec67da into main Jan 23, 2026
3 checks passed
@khaong khaong deleted the soph/do-not-truncate branch January 23, 2026 01:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes incremental transcript storage logic in the manual-commit strategy, transitioning to storing full transcripts for each checkpoint. Previously, when a session was continued and produced multiple checkpoints, only new log lines since the last checkpoint were stored. Now, the complete transcript is preserved in each checkpoint, providing full session history.

Changes:

  • Changed extractSessionData to always extract full transcripts instead of incremental portions
  • Updated CondensedTranscriptLines usage to detect new content only, not for incremental extraction
  • Updated tests to verify full transcript preservation instead of incremental behavior
  • Updated documentation to reflect the new behavior

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
docs/architecture/claude-hooks-integration.md Updated documentation to clarify that CondensedTranscriptLines is now used only to detect new content, not for incremental parsing
cmd/entire/cli/strategy/manual_commit_types.go Updated comment for ExtractedSessionData.Transcript to reflect it now contains full transcript content
cmd/entire/cli/strategy/manual_commit_hooks.go Removed startLine parameter (set to 0) from extractSessionData call in getLastPrompt
cmd/entire/cli/strategy/manual_commit_condensation.go Removed startLine parameter from extractSessionData function signature and removed incremental extraction logic; now always processes full transcript
cmd/entire/cli/integration_test/manual_commit_workflow_test.go Renamed and updated tests to verify full transcript preservation instead of incremental behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants