more hermetic separation for gemini auth config files in E2E#915
Merged
gtrrz-victor merged 3 commits intomainfrom Apr 11, 2026
Merged
more hermetic separation for gemini auth config files in E2E#915gtrrz-victor merged 3 commits intomainfrom
gtrrz-victor merged 3 commits intomainfrom
Conversation
f7f3d0d to
5cf3479
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make Gemini E2E runs more hermetic by moving Gemini auth/settings/acknowledgment files out of the real user home directory and into a per-test isolated HOME, reducing cross-test and developer-environment interference.
Changes:
- Create and populate a per-repo “Gemini test HOME” directory (settings + acknowledgments) during E2E repo setup.
- Stop writing Gemini settings into the real
~/.geminiduring agent bootstrap and instead run Gemini withHOMEpointed at the test-specific directory. - Add a new
docs/gmeta-poc-plan.mddocument (appears unrelated to the PR title/purpose).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| e2e/testutil/repo.go | Creates an isolated Gemini HOME dir per test repo and writes Gemini settings/acknowledgments there. |
| e2e/agents/gemini.go | Stops global bootstrap config writes; sets HOME for Gemini subprocesses and tmux sessions to the isolated directory. |
| docs/gmeta-poc-plan.md | Adds a gmeta POC plan document (scope seems separate from Gemini E2E hermeticity). |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
gtrrz-victor
approved these changes
Apr 11, 2026
georg
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entire-Checkpoint: 58a364f11b5f
Note
Low Risk
Low risk and test-only, but it changes how
geminiis bootstrapped and whichHOME/acknowledgment files it reads, so Gemini E2E runs could fail if the CLI expects additional state in the real home directory.Overview
Makes Gemini E2E runs hermetic by isolating Gemini CLI state into a per-repo test HOME directory. The Gemini agent no longer writes global auth config in
Bootstrap; instead,SetupRepocreates a dedicated...-gemini-homedirectory, seeds.gemini/settings.json, and writes acknowledgment state there.Gemini prompt and interactive session execution now explicitly set
HOMEto this test directory (and preserveTERMfor tmux runs), removing previous reliance on the developer’s real home directory and eliminating the prior global mutex/serialization around acknowledgments. Adds a standalonedocs/gmeta-poc-plan.mdplanning document (no production code changes).Reviewed by Cursor Bugbot for commit f7f3d0d. Configure here.