Skip to content

Add devcontainer setup#940

Merged
Soph merged 7 commits intomainfrom
ashtom/devcontainer
Apr 13, 2026
Merged

Add devcontainer setup#940
Soph merged 7 commits intomainfrom
ashtom/devcontainer

Conversation

@ashtom
Copy link
Copy Markdown
Member

@ashtom ashtom commented Apr 13, 2026

This pull request introduces a devcontainer setup. It adds a .devcontainer directory with configuration files, a custom Dockerfile, and helper scripts to automate environment provisioning, dependency installation, and keyring management. Documentation is updated to guide users on leveraging the new dev container.

Dev Container Setup:

  • Added .devcontainer/Dockerfile to define a development environment based on Ubuntu 24.04, installing essential tools and configuring the mise version manager for language and toolchain management.
  • Introduced .devcontainer/devcontainer.json to configure VS Code Dev Containers, specifying build context, user, post-create commands, editor settings, and recommended extensions for Go and shell scripting.

Automation Scripts:

  • Added .devcontainer/post-create.sh to bootstrap the repository by trusting and installing the mise toolchain and installing required Go binaries after container creation.
  • Added .devcontainer/run-with-keyring.sh to run commands within a session that unlocks the Linux keyring, supporting workflows that require secure credential storage (e.g., running tests).

Documentation:

  • Updated README.md with instructions on using the dev container, including startup commands, available tooling, and guidance for running commands that require the Linux keyring.

Entire


Note

Low Risk
Low risk: adds new devcontainer config/scripts and README docs without changing application/runtime code. Main risk is developer environment drift or tooling install failures inside the container.

Overview
Adds a new .devcontainer/ setup to standardize development in a container: an Ubuntu 24.04 Dockerfile with common dev/CI packages plus mise, a devcontainer.json that runs a post-create bootstrap, and scripts to install toolchains/binaries and to run commands with an unlocked gnome-keyring via dbus-run-session.

Updates README.md with Dev Container usage instructions and notes that keyring-dependent commands (e.g., mise run test:ci) should be run through .devcontainer/run-with-keyring.sh.

Reviewed by Cursor Bugbot for commit 9b01555. Configure here.

Entire-Checkpoint: 03ecbfaa1b6e
Copilot AI review requested due to automatic review settings April 13, 2026 14:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a VS Code Dev Container setup for the Entire CLI repo to standardize local dev/CI-like tooling (Ubuntu 24.04 + mise toolchain bootstrap), along with helper scripts and README documentation.

Changes:

  • Added .devcontainer/ with a custom Dockerfile and devcontainer.json to define the dev environment and VS Code settings/extensions.
  • Added post-create and keyring helper scripts to bootstrap mise and support running commands with a Linux keyring session.
  • Updated README.md with devcontainer usage instructions.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
README.md Documents how to start/use the devcontainer and run keyring-dependent commands.
.devcontainer/Dockerfile Defines the Ubuntu-based dev image and installs base system dependencies + mise.
.devcontainer/devcontainer.json Configures the devcontainer build, user, post-create bootstrap, and VS Code customizations.
.devcontainer/post-create.sh Bootstraps mise and installs additional Go tooling after container creation.
.devcontainer/run-with-keyring.sh Runs a command inside a D-Bus session and unlocks gnome-keyring first.

Comment thread .devcontainer/run-with-keyring.sh Outdated
Comment thread .devcontainer/post-create.sh Outdated
Comment thread README.md
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Redundant go install duplicates mise-managed tool installation
    • Removed the two redundant mise exec -- go install lines since both binaries are already declared as managed tools in mise.toml and installed by mise install.

Create PR

Or push these changes by commenting:

@cursor push 94e484d015
Preview (94e484d015)
diff --git a/.devcontainer/post-create.sh b/.devcontainer/post-create.sh
--- a/.devcontainer/post-create.sh
+++ b/.devcontainer/post-create.sh
@@ -8,5 +8,3 @@
 
 mise trust --yes
 mise install
-mise exec -- go install github.com/entireio/roger-roger/cmd/roger-roger@latest
-mise exec -- go install github.com/entireio/roger-roger/cmd/entire-agent-roger-roger@latest

This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 9b01555. Configure here.

Comment thread .devcontainer/post-create.sh Outdated
Soph
Soph previously approved these changes Apr 13, 2026
Comment thread .devcontainer/post-create.sh Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ashtom ashtom marked this pull request as ready for review April 13, 2026 14:28
@ashtom ashtom requested a review from a team as a code owner April 13, 2026 14:28
@Soph Soph enabled auto-merge April 13, 2026 14:33
@Soph Soph merged commit 12bbd44 into main Apr 13, 2026
9 checks passed
@Soph Soph deleted the ashtom/devcontainer branch April 13, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants