fix hanging summary tty in local tests#968
Merged
computermode merged 1 commit intomainfrom Apr 16, 2026
Merged
Conversation
Entire-Checkpoint: fa6d38be106a
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes local go test runs hanging due to an interactive “Choose a summary provider” prompt being triggered when a TTY is available and summary-capable agent CLIs are installed.
Changes:
- Forces non-interactive mode in three
--generateexplain-checkpoint unit tests by settingENTIRE_TEST_TTY=0to avoid the TUI prompt.
computermode
approved these changes
Apr 16, 2026
Contributor
|
Shared some thoughts outside of GH but stamping to unblock local testing ^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This worked in CI because there is no tty available and also no agents installed but it triggered on my local machine
Note
Low Risk
Test-only change that sets an env var to avoid interactive prompts; no production behavior changes.
Overview
Prevents local
go testruns from hanging by forcing summary-provider selection into non-interactive mode inexplaincheckpoint generation tests.Adds
ENTIRE_TEST_TTY=0to the v2--generate-related tests inexplain_test.goso they don’t prompt for a TTY-based provider choice when run on a developer machine.Reviewed by Cursor Bugbot for commit 978a2b7. Configure here.