Fix more TTY-dependent local CI tests#969
Merged
computermode merged 1 commit intomainfrom Apr 16, 2026
Merged
Conversation
tryAgentCommitFastPath() only fires when hasTTY() is false. This was resulting in local test failures for these tests. Entire-Checkpoint: 680f0f9d6e9a
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes nondeterministic local failures in the tryAgentCommitFastPath() unit tests by making the tests explicitly simulate a non-TTY environment, matching the conditions under which the fast path is expected to run.
Changes:
- Force
hasTTY()to return false in the relevant tests by settingENTIRE_TEST_TTY=0. - Stabilize expectations around whether the fast path fires and whether an
Entire-Checkpointtrailer is added.
pfleidi
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tryAgentCommitFastPath() only fires when hasTTY() is false.
This was resulting in local test failures for these tests.
@pfleidi and I were both running into these failures via
mise test:ciNote
Low Risk
Test-only change that sets
ENTIRE_TEST_TTY=0to make TTY detection deterministic and avoid hangs/failures in local CI; no production logic is modified.Overview
Makes the
tryAgentCommitFastPathregression tests deterministic by explicitly settingENTIRE_TEST_TTY=0sohasTTY()is forced false and the non-interactive fast path is exercised consistently.This prevents local/CI runs from unexpectedly taking the TTY-dependent path and failing to add the
Entire-Checkpointtrailer incondense_skip_test.go.Reviewed by Cursor Bugbot for commit 700aace. Configure here.