Add Docker SSH end-to-end test#56
Merged
Merged
Conversation
Entire-Checkpoint: 6f3629569e1e
Entire-Checkpoint: 9736a82de6e6
t.Context is canceled the moment the test returns, so the docker rm / docker image rm subprocesses registered via t.Cleanup were never able to run, leaking the test image (~35MB per run). Entire-Checkpoint: 74fd06e0aef8
nodo
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Stacked on top of #54.
Note
Low Risk
Low risk since changes are isolated to opt-in integration testing and developer tooling, with no production code paths modified.
Overview
Adds a new opt-in end-to-end test (
TestRun_SSHDockerSync) that spins up ansshd+ git server in Docker, injects an ephemeral SSH key/config via a wrapperssh, and verifiessyncer.Runcan bootstrap-sync from a source bare repo to a target over realgit-upload-pack/git-receive-pack.Documents how to run the Docker SSH test in
docs/testing.mdand adds amisetask (test:ssh-docker) to execute it.Reviewed by Cursor Bugbot for commit 8607211. Configure here.