Skip to content

Add Docker SSH end-to-end test#56

Merged
Soph merged 3 commits into
mainfrom
soph/ssh-e2e-docker
May 18, 2026
Merged

Add Docker SSH end-to-end test#56
Soph merged 3 commits into
mainfrom
soph/ssh-e2e-docker

Conversation

@Soph
Copy link
Copy Markdown
Contributor

@Soph Soph commented May 14, 2026

Summary

  • add an opt-in Docker-backed SSH end-to-end sync test
  • exercise real sshd plus git-upload-pack/git-receive-pack through syncer.Run
  • add a mise task and testing docs entry for the new SSH Docker test

Testing

  • env GOCACHE=/tmp/go-build go test ./internal/syncer -run 'TestRun_SSHDockerSync|TestRun_IntegrationSyncOverSSHShimV2'
  • mise run test:ssh-docker

Stacked on top of #54.


Note

Low Risk
Low risk since changes are isolated to opt-in integration testing and developer tooling, with no production code paths modified.

Overview
Adds a new opt-in end-to-end test (TestRun_SSHDockerSync) that spins up an sshd + git server in Docker, injects an ephemeral SSH key/config via a wrapper ssh, and verifies syncer.Run can bootstrap-sync from a source bare repo to a target over real git-upload-pack/git-receive-pack.

Documents how to run the Docker SSH test in docs/testing.md and adds a mise task (test:ssh-docker) to execute it.

Reviewed by Cursor Bugbot for commit 8607211. Configure here.

@Soph Soph force-pushed the soph/ssh-e2e-docker branch from c2a8f3a to 4002dc3 Compare May 15, 2026 08:39
@Soph Soph force-pushed the soph/ssh-transport branch from d9431a8 to 3b30f87 Compare May 18, 2026 14:21
Base automatically changed from soph/ssh-transport to main May 18, 2026 14:25
Soph added 3 commits May 18, 2026 16:28
Entire-Checkpoint: 6f3629569e1e
Entire-Checkpoint: 9736a82de6e6
t.Context is canceled the moment the test returns, so the docker rm /
docker image rm subprocesses registered via t.Cleanup were never able
to run, leaking the test image (~35MB per run).

Entire-Checkpoint: 74fd06e0aef8
@Soph Soph force-pushed the soph/ssh-e2e-docker branch from 4002dc3 to 8adeada Compare May 18, 2026 14:53
@Soph Soph merged commit 32e319d into main May 18, 2026
3 checks passed
@Soph Soph deleted the soph/ssh-e2e-docker branch May 18, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants