Refactor #23
Merged
Refactor #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead, add a method to get the most recent snapshot, distinguish from method that returns current state
bring your own queries
if there's no snapshot, we want it to return null, not the newly constructed entity
1. remove PreviousSnapshot from ITransactionCommand 2. test mode passes an object that controls disposal; we need this because we will be separating recording snapshots from pulling them, and end up with two different instances of ISnapshotRepository; it should not remove the entries created until all instances have been disposed
ask for the required dependencies explicitly
in test mode, will run synchronously
store transaction snapshots asynchronously, don't block or allow a failure to cause problems :)
the-avid-engineer
added
diff:add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.