Skip to content

Brittle 'AlreadyVoted' in str(e) substring check still present after PR #101 #172

@atoz96

Description

@atoz96

PR #101 introduced an is_already_voted predicate, but allways/validator/forward.py:256 and allways/validator/forward.py:397 still inline if 'AlreadyVoted' in str(e):. Whatever helper landed (or was meant to) is not used here. Either route both call sites through the centralized predicate or — if the helper was never merged — re-open it; the substring form silently breaks if the contract error type is renamed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions