fix: coerce neuron.events_retention_size to int for RotatingFileHandler#158
Open
Tmalone1250 wants to merge 1 commit intoentrius:testfrom
Open
fix: coerce neuron.events_retention_size to int for RotatingFileHandler#158Tmalone1250 wants to merge 1 commit intoentrius:testfrom
Tmalone1250 wants to merge 1 commit intoentrius:testfrom
Conversation
The --neuron.events_retention_size argument was incorrectly defined with type=str in allways/utils/config.py. This caused a TypeError when the parsed string value was passed to RotatingFileHandler(maxBytes=...) in allways/utils/logging.py, which requires an integer for comparison. Fixes entrius#154
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #154
Summary
type=strtotype=intfor the--neuron.events_retention_sizeargument inallways/utils/config.py.argparsereturns an integer instead of a string when parsing the command line.Why
The string value was being passed directly to
RotatingFileHandler(maxBytes=...)inallways/utils/logging.py. The standard library's logging handler requires an integer to perform the internalif maxBytes > 0comparison, triggering aTypeErrorand crashing the logging thread at startup if a string was provided.Behavior note
Users providing
--neuron.events_retention_sizevia CLI will no longer experience a fatal crash during initialization. The logging rotation will now correctly enforce the specified byte limit.Net
-1 line (+1 line with corrected type) in
allways/utils/config.py.Test plan
ruff check allways/ neurons/andruff format --check- both clean.pytest tests/- no new failures vs. currenttestbranch.TypeErroris resolved.Attachments
reproduce_issue_154.py
pre_fix_failure.log
post_fix_success.log