fix: reject NaN/inf rates in commitment parser#208
Open
dripsmvcp wants to merge 1 commit intoentrius:testfrom
Open
fix: reject NaN/inf rates in commitment parser#208dripsmvcp wants to merge 1 commit intoentrius:testfrom
dripsmvcp wants to merge 1 commit intoentrius:testfrom
Conversation
float('nan') and float('inf') do not raise, and the surrounding except
only catches ValueError/IndexError, so neither was rejected. An inf rate
sorted to the top of crown-holder ranking; a NaN rate dropped silently
out of comparisons. Reject any non-finite or non-positive rate.
Closes entrius#184
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #184.
float('nan')andfloat('inf')don't raise, and the surroundingexceptonly catchesValueError/IndexError, so neither was rejected by the commitment parser. Aninfrate sorted to the top of crown-holder ranking; aNaNrate dropped silently out of comparisons (NaN == NaNis False).After parsing both
rateandcounter_rate, reject any value that isn'tmath.isfiniteand> 0.Test plan
'inf'/'-inf'/'nan'rate strings returnNone0and negative rates still rejected