fix: skip axon when is_validator RPC fails in discover_validators#92
Open
nightmare0329 wants to merge 1 commit into
Open
fix: skip axon when is_validator RPC fails in discover_validators#92nightmare0329 wants to merge 1 commit into
nightmare0329 wants to merge 1 commit into
Conversation
An exception in contract_client.is_validator() was caught with pass, which fell through to axons.append(), including the axon as if the whitelist check had passed. Replace pass with continue so RPC failures are treated as unknown (exclude) rather than whitelisted (include). Closes entrius#73 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
@LandynDev @FairyPigDev ready for review. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #73
An exception from contract_client.is_validator() was caught with pass, which fell through to axons.append() — including the axon as if the whitelist check had passed. Replace pass with continue so a failing RPC is treated as unknown (exclude) rather than whitelisted (include).
Changes: