fix: backfill nested pagination#10
Closed
MkDev11 wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Closing alongside #9 — see issue note. Scope is also disproportionate (+691/-11 for full nested cursor pagination across three connections) relative to the data the mirror scorer actually consumes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix backfill pagination for nested GitHub GraphQL connections used by miner scoring inputs.
Root cause: repo backfill paginated parent PR/issue pages, but treated capped nested
reviews,labels, and labeltimelineItemsconnections as complete. Historical rows could silently miss PR reviews and label events before webhook registration.Changed behavior:
Preserved behavior:
pageInfostill persist from the initial nodes without extra fetchesRelated Issues
Closes #9
Type of Change
Testing
npm testnpm run format:checknpm run lintnpm run buildgit diff --checkLive GitHub API/E2E backfill was not run locally; coverage uses deterministic mocked GraphQL responses for paginated and non-paginated nested connections.
Checklist