Skip to content

fix: handle transient GitHub failures in validator PAT handlers (#1106)#1127

Closed
alpurkan17 wants to merge 2 commits into
entrius:testfrom
alpurkan17:fix/1012-neuron-print-to-logging
Closed

fix: handle transient GitHub failures in validator PAT handlers (#1106)#1127
alpurkan17 wants to merge 2 commits into
entrius:testfrom
alpurkan17:fix/1012-neuron-print-to-logging

Conversation

@alpurkan17
Copy link
Copy Markdown
Contributor

Description

Fix #1106 — The validator PAT handlers (handle_pat_broadcast and handle_pat_check) use the legacy validate_github_credentials() wrapper that drops the transient_failure flag. Transient GitHub /user failures are treated as invalid PATs instead of inconclusive.

Changes

  • Replace validate_github_credentials() with validate_github_credentials_result() in both handlers
  • handle_pat_broadcast: transient failure → reject with retry-oriented message
  • handle_pat_check: transient failure → pat_valid=None (inconclusive) instead of pat_valid=False

Testing

  • Transient GitHub /user failure → broadcast rejects with retry message
  • Transient GitHub /user failure → check returns pat_valid=None
  • Normal validation error → unchanged behavior
  • Valid PAT → unchanged behavior

@xiao-xiao-mao xiao-xiao-mao Bot added the bug Something isn't working label May 9, 2026
@anderdc
Copy link
Copy Markdown
Collaborator

anderdc commented May 9, 2026

Closing as duplicate of #1107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] pat_handler treats transient GitHub /user failures as invalid PATs in validator-side broadcast/check handlers

2 participants