fix: handle transient GitHub failures in validator PAT handlers (#1106)#1127
Closed
alpurkan17 wants to merge 2 commits into
Closed
fix: handle transient GitHub failures in validator PAT handlers (#1106)#1127alpurkan17 wants to merge 2 commits into
alpurkan17 wants to merge 2 commits into
Conversation
added 2 commits
May 9, 2026 03:11
Collaborator
|
Closing as duplicate of #1107 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #1106 — The validator PAT handlers (
handle_pat_broadcastandhandle_pat_check) use the legacyvalidate_github_credentials()wrapper that drops thetransient_failureflag. Transient GitHub/userfailures are treated as invalid PATs instead of inconclusive.Changes
validate_github_credentials()withvalidate_github_credentials_result()in both handlershandle_pat_broadcast: transient failure → reject with retry-oriented messagehandle_pat_check: transient failure →pat_valid=None(inconclusive) instead ofpat_valid=FalseTesting
/userfailure → broadcast rejects with retry message/userfailure → check returnspat_valid=None