fix: distinguish transient GitHub failures in validator PAT handlers (#1106)#1134
Closed
alpurkan17 wants to merge 1 commit into
Closed
fix: distinguish transient GitHub failures in validator PAT handlers (#1106)#1134alpurkan17 wants to merge 1 commit into
alpurkan17 wants to merge 1 commit into
Conversation
alpurkan17
force-pushed
the
fix/1106-pat-transient-failure
branch
from
0a5169c to
7184d2c
Compare
Collaborator
|
duplicate of #1107. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validator PAT handlers call legacy validate_github_credentials() which returns a bare tuple and discards the transient_failure flag. When GitHub /user temporarily fails (rate limit, blip), miners with valid PATs are incorrectly rejected. Replace with validate_github_credentials_result() which preserves transient_failure, and update handle_pat_check to allow transient failures when a github_id is already stored.
Validation
uv run ruff check— cleanuv run ruff format --check— cleanuv run pyright— 0 errorsuv run pytest tests/validator/test_pat_handler.py::test_transient_failure -q— 1 passedCloses [Bug]
pat_handlertreats transient GitHub/userfailures as invalid PATs in validator-side broadcast/check handlers #1106