Skip to content

test: cover emission allocation edge cases#1232

Closed
CaptainTimon wants to merge 1 commit into
entrius:testfrom
CaptainTimon:coverage/emission-allocation-cases
Closed

test: cover emission allocation edge cases#1232
CaptainTimon wants to merge 1 commit into
entrius:testfrom
CaptainTimon:coverage/emission-allocation-cases

Conversation

@CaptainTimon
Copy link
Copy Markdown

Summary

Related Issues

Part of #1215. Covers required deliverable 6 only.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other (describe below)

Test coverage for the allocation/recycle/spill behavior.

Testing

  • Tests added/updated
  • Manually tested

uv run pytest tests/validator/test_emission_allocation_coverage.py -q
uv run ruff check gittensor/validator/emission_allocation.py tests/validator/test_emission_allocation_coverage.py
uv run ruff format --check gittensor/validator/emission_allocation.py tests/validator/test_emission_allocation_coverage.py
uv run pytest -q

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Changes are documented (if applicable)

Note for reviewers: this PR intentionally adds reference coverage. The separate #1215 implementation PRs provide the config and allocation primitives that these cases pin down.

@CaptainTimon
Copy link
Copy Markdown
Author

@anderdc in my opinion this method is the most elegant, optimal, clear and safe.
could you please review my PR and give me feedback?
thanks.

@anderdc
Copy link
Copy Markdown
Collaborator

anderdc commented May 13, 2026

Fold these changes into a single PR addressing #1215, not 11 slices. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants