fix: guard handle_pat_check against deregistered hotkey TOCTOU race (#1297)#1301
Closed
alpurkan17 wants to merge 1 commit into
Closed
fix: guard handle_pat_check against deregistered hotkey TOCTOU race (#1297)#1301alpurkan17 wants to merge 1 commit into
alpurkan17 wants to merge 1 commit into
Conversation
…ntrius#1297) handle_pat_check calls metagraph.hotkeys.index(hotkey) without first verifying the hotkey is still registered. A metagraph refresh between blacklist pass and handler execution causes an uncaught ValueError that crashes the axon coroutine. Fix matches handle_pat_broadcast pattern: reject early with a clear rejection_reason when the hotkey is not in metagraph.hotkeys.
|
You already have 4 open PRs in this repo. The threshold is 3, so closing this one until a maintainer can triage your existing PRs. Please don't open any more — they'll be closed too. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handle_pat_checkcallsmetagraph.hotkeys.index(hotkey)without verifying the hotkey is still registered. A metagraph refresh between the blacklist pass and handler execution creates a TOCTOU race — the blacklist passes on a stale view, then.index()raisesValueError, crashing the axon coroutine.Every sibling function in
pat_handler.pyalready guards this correctly. This fix applies the same pattern used inhandle_pat_broadcast.Validation
uv run ruff check— cleanuv run ruff format --check— cleanCloses #1297