Refactor: unify config loading by reusing load_config from helpers#410
Closed
volcano303 wants to merge 1 commit intoentrius:testfrom
Closed
Refactor: unify config loading by reusing load_config from helpers#410volcano303 wants to merge 1 commit intoentrius:testfrom
volcano303 wants to merge 1 commit intoentrius:testfrom
Conversation
Move config loading in post.py and contract address resolution in issue_competitions.py to use centralized helpers, eliminating duplicated logic and ensuring consistent priority (CLI arg > env var > default).
volcano303
force-pushed
the
refactor/unify-config-loading
branch
from
82f428e to
82e39f9
Compare
anderdc
added a commit
that referenced
this pull request
Apr 25, 2026
End-of-phase cache stats give operators a single-line view of how the solving-PR cache performed during a scoring round: Solving-PR cache: 47 hits | 5 misses (4 fetched OK, 1 fetch failures) Hits = cache lookup (no HTTP). Misses = get_pr_files invocation. Fetch failures = MirrorRequestError raised; issue counts toward credibility but no discovery_earned_score awarded. Useful for tuning expectations (maintainer-solved miner-issues are guaranteed cache misses since maintainer PRs are dropped at OSS load time and never enter mirror_merged_prs) and for spotting mirror flakiness without scraping the warning lines. Per-issue debug logs explain every classification + scoring decision so operators can debug "why didn't UID X get credit for issue Y?" by setting the log level to debug. Each gate logs its specific reason: issue #553 (entrius/gittensor): closed-not-solved (state_reason=NOT_PLANNED, need COMPLETED) issue #480 (entrius/gittensor-ui): same-account (discoverer == solver 218712309) — credibility only issue #621 (entrius/allways): one-issue-per-PR (PR #527 already scored an earlier issue) — credibility only issue #410 (entrius/gittensor): solving PR #399 token_score 2.50 < 5 — credibility only All at debug level so they don't clutter normal info-level logs. _score_miner_mirror_issues + _resolve_solving_pr_score gain a _CacheStats parameter; callers updated. New TestCacheStats covers all three counter paths (hit / fetch-success / fetch-failure). Full suite: 618 passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_load_config_value()incli/miner_commands/post.pywith a call to the existingload_config()fromcli/issue_commands/helpers.pyget_contract_address()invalidator/utils/issue_competitions.pywith a call to the existingget_contract_address()fromcli/issue_commands/helpers.py